Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-24 Thread via GitHub
HonahX commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1689267872 ## pyiceberg/table/__init__.py: ## @@ -1956,6 +1957,10 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-23 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1688374315 ## pyiceberg/table/__init__.py: ## @@ -1956,6 +1957,10 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-07 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1667693132 ## pyiceberg/table/__init__.py: ## @@ -1956,6 +1957,10 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-07 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1667693132 ## pyiceberg/table/__init__.py: ## @@ -1956,6 +1957,10 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-07 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1667693132 ## pyiceberg/table/__init__.py: ## @@ -1956,6 +1957,10 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-07 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1667693132 ## pyiceberg/table/__init__.py: ## @@ -1956,6 +1957,10 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-04 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1665246340 ## pyiceberg/table/__init__.py: ## @@ -1975,6 +1948,52 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-04 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1665246340 ## pyiceberg/table/__init__.py: ## @@ -1975,6 +1948,52 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-04 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1665246340 ## pyiceberg/table/__init__.py: ## @@ -1975,6 +1948,52 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-03 Thread via GitHub
HonahX commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1665133966 ## pyiceberg/table/__init__.py: ## @@ -1975,6 +1948,52 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-02 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1662967631 ## pyiceberg/table/__init__.py: ## @@ -2010,6 +2016,84 @@ def create_branch( self._requirements += requirement return self +def rollba

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-02 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1663030804 ## pyiceberg/table/__init__.py: ## @@ -1956,6 +1957,10 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-02 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1662967986 ## pyiceberg/table/__init__.py: ## @@ -2010,6 +2016,84 @@ def create_branch( self._requirements += requirement return self +def rollba

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-07-02 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1662967631 ## pyiceberg/table/__init__.py: ## @@ -2010,6 +2016,84 @@ def create_branch( self._requirements += requirement return self +def rollba

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-06-17 Thread via GitHub
HonahX commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1643598048 ## pyiceberg/table/__init__.py: ## @@ -2010,6 +2016,84 @@ def create_branch( self._requirements += requirement return self +def rollback_to_

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-06-17 Thread via GitHub
HonahX commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1643598048 ## pyiceberg/table/__init__.py: ## @@ -2010,6 +2016,84 @@ def create_branch( self._requirements += requirement return self +def rollback_to_

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-06-16 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1641646010 ## pyiceberg/table/__init__.py: ## @@ -2010,6 +2016,84 @@ def create_branch( self._requirements += requirement return self +def rollba

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-06-16 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1641646010 ## pyiceberg/table/__init__.py: ## @@ -2010,6 +2016,84 @@ def create_branch( self._requirements += requirement return self +def rollba

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-06-16 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1641646010 ## pyiceberg/table/__init__.py: ## @@ -2010,6 +2016,84 @@ def create_branch( self._requirements += requirement return self +def rollba

Re: [PR] Create rollback and set snapshot APIs [iceberg-python]

2024-06-15 Thread via GitHub
chinmay-bhat commented on code in PR #758: URL: https://github.com/apache/iceberg-python/pull/758#discussion_r1641606523 ## pyiceberg/table/__init__.py: ## @@ -1956,6 +1957,10 @@ def _commit(self) -> UpdatesAndRequirements: """Apply the pending changes and commit."""

[PR] Create rollback and set snapshot APIs [iceberg-python]

2024-05-20 Thread via GitHub
chinmay-bhat opened a new pull request, #758: URL: https://github.com/apache/iceberg-python/pull/758 Creates APIs supported in Spark for snapshot manageent operations Relevant issue - #737 PR depends on #728 and #748. Ready to review once they are merged. - [x] create APIs