Re: [PR] Create publish-docker.yml [iceberg]

2024-12-03 Thread via GitHub
sungwy commented on code in PR #11632: URL: https://github.com/apache/iceberg/pull/11632#discussion_r1865927839 ## .github/workflows/publish-docker.yml: ## @@ -0,0 +1,51 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements

Re: [PR] Create publish-docker.yml [iceberg]

2024-12-02 Thread via GitHub
sungwy commented on code in PR #11632: URL: https://github.com/apache/iceberg/pull/11632#discussion_r1865927839 ## .github/workflows/publish-docker.yml: ## @@ -0,0 +1,51 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-29 Thread via GitHub
kevinjqliu commented on PR #11632: URL: https://github.com/apache/iceberg/pull/11632#issuecomment-2508360201 I saw that this action was run manually https://github.com/apache/iceberg/actions/runs/12082416551 but I cant find the image on docker https://hub.docker.com/search?q=iceberg-rest

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-29 Thread via GitHub
Fokko merged PR #11632: URL: https://github.com/apache/iceberg/pull/11632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-29 Thread via GitHub
Fokko commented on PR #11632: URL: https://github.com/apache/iceberg/pull/11632#issuecomment-2507427785 @sungwy Thanks for raising this and the thorough testing. I also did some tests against my personal Dockerhub, so let's push this forward. -- This is an automated message from the Apach

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-28 Thread via GitHub
sungwy commented on PR #11632: URL: https://github.com/apache/iceberg/pull/11632#issuecomment-2506745817 @Fokko @ajantha-bhat and @jbonofre - thank you all for the reviews on the PR! I've verified the publication using both the `tag` triggered and `workflow_dispatch` triggered workflo

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-28 Thread via GitHub
sungwy commented on code in PR #11632: URL: https://github.com/apache/iceberg/pull/11632#discussion_r1862600872 ## .github/workflows/publish-docker.yml: ## @@ -0,0 +1,51 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-28 Thread via GitHub
ajantha-bhat commented on PR #11632: URL: https://github.com/apache/iceberg/pull/11632#issuecomment-2505693725 https://github.com/apache/iceberg/pull/11283 got merged. We can move forward with this once @jbonofre share us the repo details. -- This is an automated message from the Apache

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-28 Thread via GitHub
ajantha-bhat commented on code in PR #11632: URL: https://github.com/apache/iceberg/pull/11632#discussion_r1861847640 ## .github/workflows/publish-docker.yml: ## @@ -0,0 +1,51 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agre

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-25 Thread via GitHub
jbonofre commented on code in PR #11632: URL: https://github.com/apache/iceberg/pull/11632#discussion_r1856935567 ## .github/workflows/publish-docker.yml: ## @@ -0,0 +1,51 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreemen

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-24 Thread via GitHub
sungwy commented on PR #11632: URL: https://github.com/apache/iceberg/pull/11632#issuecomment-2496635598 > in addition to pushing the latest, it would be great to publish images tagged with specific releases (1.7/1.8/etc) also, I found the GitHub action that generates the hive docker image

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-22 Thread via GitHub
kevinjqliu commented on PR #11632: URL: https://github.com/apache/iceberg/pull/11632#issuecomment-2494376136 in addition to pushing the latest, it would be great to publish images tagged with specific releases (1.7/1.8/etc) also, I found the GitHub action that generates the hive docker im

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-22 Thread via GitHub
sungwy commented on PR #11632: URL: https://github.com/apache/iceberg/pull/11632#issuecomment-2494376574 > I was waiting for the account creation. But thanks for working on it. I think many of us are eager to get the docker image in the hub to improve our integration tests in the sub

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-22 Thread via GitHub
ajantha-bhat commented on PR #11632: URL: https://github.com/apache/iceberg/pull/11632#issuecomment-2494321802 I was waiting for the account creation. But thanks for working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-22 Thread via GitHub
sungwy commented on code in PR #11632: URL: https://github.com/apache/iceberg/pull/11632#discussion_r1854251098 ## .github/workflows/publish-docker.yml: ## @@ -0,0 +1,38 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements

Re: [PR] Create publish-docker.yml [iceberg]

2024-11-22 Thread via GitHub
Fokko commented on code in PR #11632: URL: https://github.com/apache/iceberg/pull/11632#discussion_r1854121432 ## .github/workflows/publish-docker.yml: ## @@ -0,0 +1,38 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.