Re: [PR] Core:support http lock-manager [iceberg]

2024-07-14 Thread via GitHub
BsoBird closed pull request #10688: Core:support http lock-manager URL: https://github.com/apache/iceberg/pull/10688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Core:support http lock-manager [iceberg]

2024-07-13 Thread via GitHub
BsoBird commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1676850504 ## core/src/main/java/org/apache/iceberg/lock/ServerSideHttpLockManager.java: ## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Core:support http lock-manager [iceberg]

2024-07-13 Thread via GitHub
BsoBird commented on code in PR #10688: URL: https://github.com/apache/iceberg/pull/10688#discussion_r1675607925 ## core/src/main/java/org/apache/iceberg/lock/ServerSideHttpLockManager.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Core:support http lock-manager [iceberg]

2024-07-13 Thread via GitHub
BsoBird commented on PR #10688: URL: https://github.com/apache/iceberg/pull/10688#issuecomment-2226845799 @snazy Hello.I'm so glad you could get back to me. I'm just saying out loud the first thing that comes to mind: 1. Is everything done using rest-catalog? In many cases, use

Re: [PR] Core:support http lock-manager [iceberg]

2024-07-13 Thread via GitHub
snazy commented on PR #10688: URL: https://github.com/apache/iceberg/pull/10688#issuecomment-2226834838 It seems there are lot of individual points that should be discussed. @BsoBird do you mind adding a point to the "Discussions" section on the [agenda for the next community sync on July