Re: [PR] Core: don't override `LoggingMetricsReporter` [iceberg]

2025-01-29 Thread via GitHub
nastra commented on PR #12092: URL: https://github.com/apache/iceberg/pull/12092#issuecomment-2621887691 > Hi @mst , I was looking at this code myself recently too. Initially I also thought that we shouldn't swap LoggingMetricsReporter here and we should combine it with the one received as

Re: [PR] Core: don't override `LoggingMetricsReporter` [iceberg]

2025-01-29 Thread via GitHub
nastra closed pull request #12092: Core: don't override `LoggingMetricsReporter` URL: https://github.com/apache/iceberg/pull/12092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Core: don't override `LoggingMetricsReporter` [iceberg]

2025-01-29 Thread via GitHub
nastra commented on PR #12092: URL: https://github.com/apache/iceberg/pull/12092#issuecomment-2621884278 > Hi @mst , I was looking at this code myself recently too. Initially I also thought that we shouldn't swap LoggingMetricsReporter here and we should combine it with the one received as

Re: [PR] Core: don't override `LoggingMetricsReporter` [iceberg]

2025-01-29 Thread via GitHub
gaborkaszab commented on PR #12092: URL: https://github.com/apache/iceberg/pull/12092#issuecomment-2621101631 Hi @mst , I was looking at this code myself recently too. Initially I also thought that we shouldn't swap LoggingMetricsReporter here and we should combine it with the one receiv