Re: [PR] Core: Update TableMetadataParser to close streams [iceberg]

2024-10-14 Thread via GitHub
erik-grepr commented on PR #11220: URL: https://github.com/apache/iceberg/pull/11220#issuecomment-2411870347 Should be good to re-run the workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Core: Update TableMetadataParser to close streams [iceberg]

2024-10-12 Thread via GitHub
findepi commented on PR #11220: URL: https://github.com/apache/iceberg/pull/11220#issuecomment-2408666274 @erik-grepr can you please review the build results? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Core: Update TableMetadataParser to close streams [iceberg]

2024-10-12 Thread via GitHub
findepi commented on code in PR #11220: URL: https://github.com/apache/iceberg/pull/11220#discussion_r1797751041 ## core/src/main/java/org/apache/iceberg/TableMetadataParser.java: ## @@ -122,13 +122,23 @@ public static void write(TableMetadata metadata, OutputFile outputFile) {