amogh-jahagirdar commented on PR #11323:
URL: https://github.com/apache/iceberg/pull/11323#issuecomment-2437961434
The change looks good to me, I'll go ahead and merge since @rdblue comment
was addressed. Thanks for the improvement @nastra , and for the reviews
@singhpk234 @rdblue!
--
T
amogh-jahagirdar merged PR #11323:
URL: https://github.com/apache/iceberg/pull/11323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
nastra commented on code in PR #11323:
URL: https://github.com/apache/iceberg/pull/11323#discussion_r1816392058
##
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##
@@ -138,20 +138,16 @@ protected boolean isCaseSensitive() {
}
protected PartitionSpec
rdblue commented on code in PR #11323:
URL: https://github.com/apache/iceberg/pull/11323#discussion_r1815781801
##
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##
@@ -138,20 +138,16 @@ protected boolean isCaseSensitive() {
}
protected PartitionSpec
rdblue commented on PR #11323:
URL: https://github.com/apache/iceberg/pull/11323#issuecomment-2436467451
One comment. Otherwise this look good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
nastra commented on code in PR #11323:
URL: https://github.com/apache/iceberg/pull/11323#discussion_r1801684210
##
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##
@@ -138,20 +138,16 @@ protected boolean isCaseSensitive() {
}
protected PartitionSpec
