Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-09 Thread via GitHub
aokolnychyi commented on PR #9000: URL: https://github.com/apache/iceberg/pull/9000#issuecomment-1804811157 Thank you, @singhpk234 @RussellSpitzer! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-09 Thread via GitHub
aokolnychyi merged PR #9000: URL: https://github.com/apache/iceberg/pull/9000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-09 Thread via GitHub
aokolnychyi closed pull request #9000: Core: Support replacing delete manifests URL: https://github.com/apache/iceberg/pull/9000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-09 Thread via GitHub
aokolnychyi commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1388322693 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,530 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-09 Thread via GitHub
aokolnychyi commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1388322693 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,530 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-09 Thread via GitHub
RussellSpitzer commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1388316731 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,530 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-09 Thread via GitHub
RussellSpitzer commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1388316731 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,530 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-09 Thread via GitHub
aokolnychyi commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1388159792 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,499 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-09 Thread via GitHub
aokolnychyi commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1388159792 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,499 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-09 Thread via GitHub
RussellSpitzer commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1387975982 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,499 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-08 Thread via GitHub
aokolnychyi closed pull request #9000: Core: Support replacing delete manifests URL: https://github.com/apache/iceberg/pull/9000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-08 Thread via GitHub
aokolnychyi commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1387249948 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,499 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-08 Thread via GitHub
aokolnychyi commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1387199381 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,499 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-08 Thread via GitHub
aokolnychyi commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1387200273 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,499 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-08 Thread via GitHub
RussellSpitzer commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1387199271 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,499 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-08 Thread via GitHub
aokolnychyi commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1387199381 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,499 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-08 Thread via GitHub
aokolnychyi commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1387199381 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,499 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-08 Thread via GitHub
RussellSpitzer commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1387196142 ## core/src/test/java/org/apache/iceberg/TestRewriteManifests.java: ## @@ -1105,6 +1108,499 @@ public void testRewriteManifestsOnBranchUnsupported() {

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-07 Thread via GitHub
aokolnychyi commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1385766686 ## core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java: ## @@ -242,7 +241,7 @@ private void performRewrite(List currentManifests) { .execute

Re: [PR] Core: Support replacing delete manifests [iceberg]

2023-11-07 Thread via GitHub
aokolnychyi commented on code in PR #9000: URL: https://github.com/apache/iceberg/pull/9000#discussion_r1385766686 ## core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java: ## @@ -242,7 +241,7 @@ private void performRewrite(List currentManifests) { .execute

[PR] Core: Support replacing delete manifests [iceberg]

2023-11-07 Thread via GitHub
aokolnychyi opened a new pull request, #9000: URL: https://github.com/apache/iceberg/pull/9000 This PR enables delete manifest replacement, basis for delete manifest compaction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub