manuzhang closed pull request #9888: Core: Support IncrementalChangelogScan
with deletes
URL: https://github.com/apache/iceberg/pull/9888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
manuzhang commented on PR #9888:
URL: https://github.com/apache/iceberg/pull/9888#issuecomment-2323761129
Closed in favor of #10935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
github-actions[bot] commented on PR #6182:
URL: https://github.com/apache/iceberg/pull/6182#issuecomment-2307945917
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
wypoon commented on code in PR #9888:
URL: https://github.com/apache/iceberg/pull/9888#discussion_r1720445018
##
core/src/main/java/org/apache/iceberg/BaseIncrementalChangelogScan.java:
##
@@ -134,50 +138,81 @@ private static Map
computeSnapshotOrdinals(Deque snapsh
}
p
wypoon commented on PR #9888:
URL: https://github.com/apache/iceberg/pull/9888#issuecomment-2294424912
You have made changes in `BaseIncrementalChangelogScan` that produces
`BaseDeletedRowsScanTask` in certain cases. However, you have not made changes
in the Spark `ChangelogRowReader` to ha
manuzhang commented on PR #6182:
URL: https://github.com/apache/iceberg/pull/6182#issuecomment-1982827028
I just submitted https://github.com/apache/iceberg/pull/9888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
manuzhang opened a new pull request, #9888:
URL: https://github.com/apache/iceberg/pull/9888
Pick up #6182 with an alternative implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
Reo-LEI commented on PR #6182:
URL: https://github.com/apache/iceberg/pull/6182#issuecomment-1954152890
> @Reo-LEI and @aokolnychyi, are you still working on this?
Sorry for the late reply. I haven't been doing this recently. You can
continue to push forward. @manuzhang
--
This is
manuzhang commented on PR #6182:
URL: https://github.com/apache/iceberg/pull/6182#issuecomment-1923299165
@Reo-LEI and @aokolnychyi, are you still working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
