Re: [PR] Core: Reimplement CharSequenceMap to obey Map contract [iceberg]

2024-12-05 Thread via GitHub
findepi commented on PR #11308: URL: https://github.com/apache/iceberg/pull/11308#issuecomment-2519557788 Follow-up: https://github.com/apache/iceberg/pull/11704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Core: Reimplement CharSequenceMap to obey Map contract [iceberg]

2024-11-23 Thread via GitHub
github-actions[bot] closed pull request #11308: Core: Reimplement CharSequenceMap to obey Map contract URL: https://github.com/apache/iceberg/pull/11308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Core: Reimplement CharSequenceMap to obey Map contract [iceberg]

2024-11-23 Thread via GitHub
github-actions[bot] commented on PR #11308: URL: https://github.com/apache/iceberg/pull/11308#issuecomment-2495713858 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Core: Reimplement CharSequenceMap to obey Map contract [iceberg]

2024-11-15 Thread via GitHub
github-actions[bot] commented on PR #11308: URL: https://github.com/apache/iceberg/pull/11308#issuecomment-2480194387 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core: Reimplement CharSequenceMap to obey Map contract [iceberg]

2024-10-12 Thread via GitHub
findepi commented on PR #11308: URL: https://github.com/apache/iceberg/pull/11308#issuecomment-2408713077 draft - let me explore one more possible approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Core: Reimplement CharSequenceMap to obey Map contract [iceberg]

2024-10-12 Thread via GitHub
findepi commented on PR #11308: URL: https://github.com/apache/iceberg/pull/11308#issuecomment-2408692023 A probably even better fix would be to use `Map` directly and perhaps using Guava's `Equivalence`. Guava doesn't plan to have transparent equivalence-based maps (https://github.com/goo

[PR] Core: Reimplement CharSequenceMap to obey Map contract [iceberg]

2024-10-12 Thread via GitHub
findepi opened a new pull request, #11308: URL: https://github.com/apache/iceberg/pull/11308 The previous `CharSequenceMap` implementation did not follow general `Map` contract. For example, `Map.keySet()` should be a live view of the keys in the map, but it was a copy. This commit reimplem