rdblue commented on PR #12167:
URL: https://github.com/apache/iceberg/pull/12167#issuecomment-2635332665
Thanks for reviewing, @amogh-jahagirdar!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
amogh-jahagirdar merged PR #12167:
URL: https://github.com/apache/iceberg/pull/12167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
rdblue commented on code in PR #12167:
URL: https://github.com/apache/iceberg/pull/12167#discussion_r1941900883
##
core/src/main/java/org/apache/iceberg/variants/VariantMetadata.java:
##
@@ -34,4 +35,12 @@ public interface VariantMetadata extends Variants.Serialized
{
/**
rdblue commented on code in PR #12167:
URL: https://github.com/apache/iceberg/pull/12167#discussion_r1941595188
##
core/src/main/java/org/apache/iceberg/variants/VariantMetadata.java:
##
@@ -34,4 +35,12 @@ public interface VariantMetadata extends Variants.Serialized
{
/**
amogh-jahagirdar commented on code in PR #12167:
URL: https://github.com/apache/iceberg/pull/12167#discussion_r1940434089
##
core/src/main/java/org/apache/iceberg/variants/VariantMetadata.java:
##
@@ -34,4 +35,12 @@ public interface VariantMetadata extends Variants.Serialized
{
rdblue opened a new pull request, #12167:
URL: https://github.com/apache/iceberg/pull/12167
This refactors the existing Variant class structure to avoid breaking
changes when the Variant interfaces are moved to core. This requries:
* `PhysicalType` should not be a static class in `Var
