Re: [PR] Core: Lookup targeted position deletes by path [iceberg]

2023-12-13 Thread via GitHub
aokolnychyi commented on code in PR #9251: URL: https://github.com/apache/iceberg/pull/9251#discussion_r1425822122 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -474,68 +421,52 @@ private Collection loadDeleteFiles() { DeleteFileIndex build() {

Re: [PR] Core: Lookup targeted position deletes by path [iceberg]

2023-12-13 Thread via GitHub
aokolnychyi commented on code in PR #9251: URL: https://github.com/apache/iceberg/pull/9251#discussion_r1425379313 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -582,97 +524,214 @@ private Iterable>> deleteManifestRea } } - // a group of indexe

Re: [PR] Core: Lookup targeted position deletes by path [iceberg]

2023-12-13 Thread via GitHub
aokolnychyi commented on code in PR #9251: URL: https://github.com/apache/iceberg/pull/9251#discussion_r1425377180 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -582,93 +513,187 @@ private Iterable>> deleteManifestRea } } - // a group of indexe

Re: [PR] Core: Lookup targeted position deletes by path [iceberg]

2023-12-13 Thread via GitHub
aokolnychyi commented on code in PR #9251: URL: https://github.com/apache/iceberg/pull/9251#discussion_r1425376250 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -474,68 +421,52 @@ private Collection loadDeleteFiles() { DeleteFileIndex build() {

Re: [PR] Core: Lookup targeted position deletes by path [iceberg]

2023-12-13 Thread via GitHub
aokolnychyi commented on code in PR #9251: URL: https://github.com/apache/iceberg/pull/9251#discussion_r1425372419 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -582,93 +513,187 @@ private Iterable>> deleteManifestRea } } - // a group of indexe

Re: [PR] Core: Lookup targeted position deletes by path [iceberg]

2023-12-13 Thread via GitHub
aokolnychyi commented on code in PR #9251: URL: https://github.com/apache/iceberg/pull/9251#discussion_r1425375381 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -582,93 +513,187 @@ private Iterable>> deleteManifestRea } } - // a group of indexe

Re: [PR] Core: Lookup targeted position deletes by path [iceberg]

2023-12-13 Thread via GitHub
aokolnychyi commented on code in PR #9251: URL: https://github.com/apache/iceberg/pull/9251#discussion_r1425372419 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -582,93 +513,187 @@ private Iterable>> deleteManifestRea } } - // a group of indexe

Re: [PR] Core: Lookup targeted position deletes by path [iceberg]

2023-12-13 Thread via GitHub
aokolnychyi commented on code in PR #9251: URL: https://github.com/apache/iceberg/pull/9251#discussion_r1425370701 ## core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: ## @@ -320,4 +320,29 @@ public static boolean isStrictlyAscending(long[] array) { return true;

Re: [PR] Core: Lookup targeted position deletes by path [iceberg]

2023-12-13 Thread via GitHub
aokolnychyi commented on code in PR #9251: URL: https://github.com/apache/iceberg/pull/9251#discussion_r1425370277 ## core/src/main/java/org/apache/iceberg/util/ArrayUtil.java: ## @@ -320,4 +320,29 @@ public static boolean isStrictlyAscending(long[] array) { return true;

Re: [PR] Core: Lookup targeted position deletes by path [iceberg]

2023-12-13 Thread via GitHub
aokolnychyi commented on code in PR #9251: URL: https://github.com/apache/iceberg/pull/9251#discussion_r1425368136 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -474,68 +421,52 @@ private Collection loadDeleteFiles() { DeleteFileIndex build() {

Re: [PR] Core: Lookup targeted position deletes by path [iceberg]

2023-12-12 Thread via GitHub
szehon-ho commented on code in PR #9251: URL: https://github.com/apache/iceberg/pull/9251#discussion_r1424802087 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -474,68 +421,52 @@ private Collection loadDeleteFiles() { DeleteFileIndex build() { I

Re: [PR] Core: Lookup targeted position deletes by path [iceberg]

2023-12-12 Thread via GitHub
szehon-ho commented on code in PR #9251: URL: https://github.com/apache/iceberg/pull/9251#discussion_r1424766968 ## core/src/main/java/org/apache/iceberg/DeleteFileIndex.java: ## @@ -582,93 +513,187 @@ private Iterable>> deleteManifestRea } } - // a group of indexed

Re: [PR] Core: Lookup targeted position deletes by path [iceberg]

2023-12-12 Thread via GitHub
aokolnychyi commented on PR #9251: URL: https://github.com/apache/iceberg/pull/9251#issuecomment-1851931126 @szehon-ho @RussellSpitzer @flyrain @amogh-jahagirdar @nastra @Fokko, could you check this one? -- This is an automated message from the Apache Git Service. To respond to the messag