pvary commented on PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#issuecomment-2688197241
Thanks @stevenzwu and @RussellSpitzer!
I will be OOO next week, so the next PR will come after that
--
This is an automated message from the Apache Git Service.
To respond to the mess
stevenzwu commented on PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#issuecomment-2686570993
yes, current state looks good to me. let me merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
stevenzwu merged PR #12306:
URL: https://github.com/apache/iceberg/pull/12306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
RussellSpitzer commented on PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#issuecomment-2685588950
Ok I'm on board, I think the interfaces are good and Java Doc is solid for
now, if @stevenzwu is good with the changes I say we merge and start the rest
of the refactor.
--
Th
pvary commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1965208778
##
core/src/main/java/org/apache/iceberg/actions/FileRewriteRunner.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
pvary commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1965214008
##
core/src/main/java/org/apache/iceberg/actions/RewriteGroupBase.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
pvary commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1965209565
##
core/src/main/java/org/apache/iceberg/actions/RewriteGroupBase.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
pvary commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1965208153
##
core/src/main/java/org/apache/iceberg/actions/FileRewritePlan.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
RussellSpitzer commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1963939995
##
core/src/main/java/org/apache/iceberg/actions/RewriteGroupBase.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
RussellSpitzer commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1963950250
##
core/src/main/java/org/apache/iceberg/actions/RewriteGroupBase.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
RussellSpitzer commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1963948180
##
core/src/main/java/org/apache/iceberg/actions/RewriteGroupBase.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
RussellSpitzer commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1963948180
##
core/src/main/java/org/apache/iceberg/actions/RewriteGroupBase.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
RussellSpitzer commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1963944890
##
core/src/main/java/org/apache/iceberg/actions/RewriteGroupBase.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
RussellSpitzer commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1963939995
##
core/src/main/java/org/apache/iceberg/actions/RewriteGroupBase.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
RussellSpitzer commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1963878608
##
core/src/main/java/org/apache/iceberg/actions/FileRewritePlanner.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
RussellSpitzer commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1963879716
##
core/src/main/java/org/apache/iceberg/actions/FileRewriteRunner.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
RussellSpitzer commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1963878608
##
core/src/main/java/org/apache/iceberg/actions/FileRewritePlanner.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
RussellSpitzer commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1963868582
##
core/src/main/java/org/apache/iceberg/actions/FileRewritePlan.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
RussellSpitzer commented on code in PR #12306:
URL: https://github.com/apache/iceberg/pull/12306#discussion_r1963861306
##
core/src/main/java/org/apache/iceberg/actions/FileRewritePlan.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
19 matches
Mail list logo
