Re: [PR] Core: Implement equals/hashCode method for RESTResponse [iceberg]

2024-10-08 Thread via GitHub
github-actions[bot] closed pull request #9049: Core: Implement equals/hashCode method for RESTResponse URL: https://github.com/apache/iceberg/pull/9049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Core: Implement equals/hashCode method for RESTResponse [iceberg]

2024-10-08 Thread via GitHub
github-actions[bot] commented on PR #9049: URL: https://github.com/apache/iceberg/pull/9049#issuecomment-2401027296 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Core: Implement equals/hashCode method for RESTResponse [iceberg]

2023-12-06 Thread via GitHub
liurenjie1024 commented on code in PR #9049: URL: https://github.com/apache/iceberg/pull/9049#discussion_r1416984941 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -846,6 +846,92 @@ private static Map validateRefs( return inputRefs; } + @Override +

Re: [PR] Core: Implement equals/hashCode method for RESTResponse [iceberg]

2023-12-06 Thread via GitHub
liurenjie1024 commented on code in PR #9049: URL: https://github.com/apache/iceberg/pull/9049#discussion_r1416984941 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -846,6 +846,92 @@ private static Map validateRefs( return inputRefs; } + @Override +

Re: [PR] Core: Implement equals/hashCode method for RESTResponse [iceberg]

2023-12-06 Thread via GitHub
nastra commented on code in PR #9049: URL: https://github.com/apache/iceberg/pull/9049#discussion_r1416913245 ## api/src/main/java/org/apache/iceberg/Schema.java: ## @@ -507,4 +508,25 @@ public String toString() { .map(this::identifierFieldToString)

Re: [PR] Core: Implement equals/hashCode method for RESTResponse [iceberg]

2023-11-30 Thread via GitHub
liurenjie1024 commented on code in PR #9049: URL: https://github.com/apache/iceberg/pull/9049#discussion_r1411655908 ## api/src/main/java/org/apache/iceberg/Schema.java: ## @@ -507,4 +508,25 @@ public String toString() { .map(this::identifierFieldToString)

Re: [PR] Core: Implement equals/hashCode method for RESTResponse [iceberg]

2023-11-30 Thread via GitHub
Fokko commented on code in PR #9049: URL: https://github.com/apache/iceberg/pull/9049#discussion_r1411644693 ## core/src/main/java/org/apache/iceberg/TableMetadata.java: ## @@ -846,6 +846,92 @@ private static Map validateRefs( return inputRefs; } + @Override + @Suppr