gaborkaszab commented on PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#issuecomment-2591938631
Thanks for the reviews @manuzhang @wypoon @pvary @nastra !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
nastra merged PR #11738:
URL: https://github.com/apache/iceberg/pull/11738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
nastra commented on PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#issuecomment-2590458971
merging as the CI failure isn't related to the changes being proposed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
nastra commented on PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#issuecomment-2590097929
@gaborkaszab can you rebase please to fix CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gaborkaszab opened a new pull request, #11738:
URL: https://github.com/apache/iceberg/pull/11738
If a regular table had a metadata table name then CachingCatalog throws a
NoSuchTableException when loading that table.
--
This is an automated message from the Apache Git Service.
To respond
nastra closed pull request #11738: Core: Fix loading a table in CachingCatalog
with metadata table name
URL: https://github.com/apache/iceberg/pull/11738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gaborkaszab commented on code in PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#discussion_r1913194574
##
core/src/test/java/org/apache/iceberg/hadoop/TestCachingCatalog.java:
##
@@ -166,6 +168,42 @@ public void testTableName() throws Exception {
.isEqualT
nastra commented on code in PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#discussion_r1913050734
##
core/src/test/java/org/apache/iceberg/hadoop/TestCachingCatalog.java:
##
@@ -166,6 +168,42 @@ public void testTableName() throws Exception {
.isEqualTo("ha
nastra commented on PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#issuecomment-2577996633
I'll take a look at this in the next few days
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gaborkaszab commented on PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#issuecomment-2575561645
Maybe @danielcweeks @pvary @nastra: Would you mind taking a look at this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wypoon commented on code in PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#discussion_r1889531352
##
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##
@@ -144,14 +144,16 @@ public Table loadTable(TableIdentifier ident) {
return cached;
}
-
gaborkaszab commented on PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#issuecomment-2540849458
I see you have made changes previously in CachingCatalog, @rdblue
@aokolnychyi @RussellSpitzer . Would you mind taking a look at this PR?
--
This is an automated message from the
gaborkaszab commented on code in PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#discussion_r1878337162
##
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##
@@ -144,14 +144,16 @@ public Table loadTable(TableIdentifier ident) {
return cached;
manuzhang commented on code in PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#discussion_r1878295947
##
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##
@@ -144,14 +144,16 @@ public Table loadTable(TableIdentifier ident) {
return cached;
}
gaborkaszab commented on PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#issuecomment-2531342789
This is an alternative solution to
https://github.com/apache/iceberg/pull/11123/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
gaborkaszab opened a new pull request, #11738:
URL: https://github.com/apache/iceberg/pull/11738
If a regular table had a metadata table name then CachingCatalog throws a
NoSuchTableException when loading that table.
--
This is an automated message from the Apache Git Service.
To respond
16 matches
Mail list logo
