Re: [PR] Core: Don't reset snapshotLog in `TableMetadata.removeRef` method [iceberg]

2024-12-24 Thread via GitHub
amogh-jahagirdar merged PR #11779: URL: https://github.com/apache/iceberg/pull/11779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Core: Don't reset snapshotLog in `TableMetadata.removeRef` method [iceberg]

2024-12-23 Thread via GitHub
ebyhr commented on PR #11779: URL: https://github.com/apache/iceberg/pull/11779#issuecomment-2560579572 @amogh-jahagirdar Thanks for your review. Addressed comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Core: Don't reset snapshotLog in `TableMetadata.removeRef` method [iceberg]

2024-12-23 Thread via GitHub
amogh-jahagirdar commented on code in PR #11779: URL: https://github.com/apache/iceberg/pull/11779#discussion_r1896074073 ## core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java: ## @@ -2418,6 +2421,34 @@ public void testPaginationForListTables(int numberOfItems) {

Re: [PR] Core: Don't reset snapshotLog in `TableMetadata.removeRef` method [iceberg]

2024-12-22 Thread via GitHub
ebyhr commented on PR #11779: URL: https://github.com/apache/iceberg/pull/11779#issuecomment-2558801986 @amogh-jahagirdar There is no reason to disagree from my perspective. I was simply trying to keep the existing behavior because I didn't know the historical reason. Reverted most changes