Re: [PR] Core: Check referencedDataFile existence for DV [iceberg]

2025-01-28 Thread via GitHub
nastra merged PR #12088: URL: https://github.com/apache/iceberg/pull/12088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: Check referencedDataFile existence for DV [iceberg]

2025-01-27 Thread via GitHub
nastra commented on code in PR #12088: URL: https://github.com/apache/iceberg/pull/12088#discussion_r1930127966 ## core/src/test/java/org/apache/iceberg/TestDeleteFiles.java: ## @@ -443,6 +444,31 @@ public void testDeleteFilesNoValidation() { assertThat(delete2.removedDataF

Re: [PR] Core: Check referencedDataFile existence for DV [iceberg]

2025-01-26 Thread via GitHub
ebyhr commented on code in PR #12088: URL: https://github.com/apache/iceberg/pull/12088#discussion_r1929470728 ## core/src/main/java/org/apache/iceberg/FileMetadata.java: ## @@ -255,6 +255,8 @@ public DeleteFile build() { if (format == FileFormat.PUFFIN) { Precon

Re: [PR] Core: Check referencedDataFile existence for DV [iceberg]

2025-01-24 Thread via GitHub
ebyhr commented on code in PR #12088: URL: https://github.com/apache/iceberg/pull/12088#discussion_r1929470728 ## core/src/main/java/org/apache/iceberg/FileMetadata.java: ## @@ -255,6 +255,8 @@ public DeleteFile build() { if (format == FileFormat.PUFFIN) { Precon

Re: [PR] Core: Check referencedDataFile existence for DV [iceberg]

2025-01-24 Thread via GitHub
amogh-jahagirdar commented on code in PR #12088: URL: https://github.com/apache/iceberg/pull/12088#discussion_r1929076093 ## core/src/main/java/org/apache/iceberg/FileMetadata.java: ## @@ -255,6 +255,8 @@ public DeleteFile build() { if (format == FileFormat.PUFFIN) {