Re: [PR] Core: Allow missing object in ErrorResponse [iceberg]

2023-10-10 Thread via GitHub
Fokko closed pull request #8760: Core: Allow missing object in ErrorResponse URL: https://github.com/apache/iceberg/pull/8760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Core: Allow missing object in ErrorResponse [iceberg]

2023-10-10 Thread via GitHub
Fokko commented on PR #8760: URL: https://github.com/apache/iceberg/pull/8760#issuecomment-1755602836 Let's do this the other way around -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Core: Allow missing object in ErrorResponse [iceberg]

2023-10-10 Thread via GitHub
Fokko commented on code in PR #8760: URL: https://github.com/apache/iceberg/pull/8760#discussion_r1352243492 ## core/src/main/java/org/apache/iceberg/rest/responses/ErrorResponse.java: ## @@ -22,18 +22,17 @@ import java.io.StringWriter; import java.util.Arrays; import java.ut

Re: [PR] Core: Allow missing object in ErrorResponse [iceberg]

2023-10-10 Thread via GitHub
Fokko commented on code in PR #8760: URL: https://github.com/apache/iceberg/pull/8760#discussion_r1352239032 ## core/src/main/java/org/apache/iceberg/rest/responses/ErrorResponseParser.java: ## @@ -76,17 +76,20 @@ public static ErrorResponse fromJson(JsonNode jsonNode) {

Re: [PR] Core: Allow missing object in ErrorResponse [iceberg]

2023-10-10 Thread via GitHub
amogh-jahagirdar commented on code in PR #8760: URL: https://github.com/apache/iceberg/pull/8760#discussion_r135149 ## core/src/main/java/org/apache/iceberg/rest/responses/ErrorResponse.java: ## @@ -22,18 +22,17 @@ import java.io.StringWriter; import java.util.Arrays; imp

Re: [PR] Core: Allow missing object in ErrorResponse [iceberg]

2023-10-10 Thread via GitHub
amogh-jahagirdar commented on code in PR #8760: URL: https://github.com/apache/iceberg/pull/8760#discussion_r1352021537 ## core/src/main/java/org/apache/iceberg/rest/responses/ErrorResponseParser.java: ## @@ -76,17 +76,20 @@ public static ErrorResponse fromJson(JsonNode jsonNode