Re: [PR] Core: Add test for renaming table to a non-existing namespace [iceberg]

2024-03-08 Thread via GitHub
nastra merged PR #9895: URL: https://github.com/apache/iceberg/pull/9895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Core: Add test for renaming table to a non-existing namespace [iceberg]

2024-03-08 Thread via GitHub
nastra commented on PR #9895: URL: https://github.com/apache/iceberg/pull/9895#issuecomment-1985258825 thanks everyone for reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Core: Add test for renaming table to a non-existing namespace [iceberg]

2024-03-07 Thread via GitHub
nastra commented on code in PR #9895: URL: https://github.com/apache/iceberg/pull/9895#discussion_r1517287773 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -228,6 +228,10 @@ public void renameTable(TableIdentifier from, TableIdentifier original

Re: [PR] Core: Add test for renaming table to a non-existing namespace [iceberg]

2024-03-07 Thread via GitHub
nastra commented on code in PR #9895: URL: https://github.com/apache/iceberg/pull/9895#discussion_r1516434260 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -226,6 +226,12 @@ public void renameTable(TableIdentifier from, TableIdentifier original

Re: [PR] Core: Add test for renaming table to a non-existing namespace [iceberg]

2024-03-07 Thread via GitHub
nastra commented on code in PR #9895: URL: https://github.com/apache/iceberg/pull/9895#discussion_r1516434260 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ## @@ -226,6 +226,12 @@ public void renameTable(TableIdentifier from, TableIdentifier original