Re: [PR] Core: Add option to fallback to thread classloader [iceberg]

2025-03-24 Thread via GitHub
bryanck commented on PR #12613: URL: https://github.com/apache/iceberg/pull/12613#issuecomment-2749629934 I made the change to always fallback to the thread's classloader. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Core: Add option to fallback to thread classloader [iceberg]

2025-03-24 Thread via GitHub
nastra merged PR #12613: URL: https://github.com/apache/iceberg/pull/12613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Core: Add option to fallback to thread classloader [iceberg]

2025-03-24 Thread via GitHub
bryanck commented on PR #12613: URL: https://github.com/apache/iceberg/pull/12613#issuecomment-2748939383 Yes I agree, I was thinking we should remove the option. I'll make that change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Core: Add option to fallback to thread classloader [iceberg]

2025-03-24 Thread via GitHub
danielcweeks commented on PR #12613: URL: https://github.com/apache/iceberg/pull/12613#issuecomment-2748932917 I agree it's safe. The only reservation I have is that maybe we should just make this the default behavior? If we fallback in some places and not others, it could result in reall

Re: [PR] Core: Add option to fallback to thread classloader [iceberg]

2025-03-24 Thread via GitHub
bryanck commented on PR #12613: URL: https://github.com/apache/iceberg/pull/12613#issuecomment-2748039970 Sounds good, it would be nice to get rid of the option if that seems acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] Core: Add option to fallback to thread classloader [iceberg]

2025-03-22 Thread via GitHub
bryanck opened a new pull request, #12613: URL: https://github.com/apache/iceberg/pull/12613 Spark loads jars from the classpath into the app classloader. The Spark submit command loads jars specified in the command into a classloader that is a child of the app classloader. If the Iceberg j