Re: [PR] Core: Add StandardEncryptionManager [iceberg]

2023-12-12 Thread via GitHub
rdblue commented on PR #9277: URL: https://github.com/apache/iceberg/pull/9277#issuecomment-1852557672 Thanks for the final review, @RussellSpitzer! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Core: Add StandardEncryptionManager [iceberg]

2023-12-12 Thread via GitHub
rdblue merged PR #9277: URL: https://github.com/apache/iceberg/pull/9277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Core: Add StandardEncryptionManager [iceberg]

2023-12-12 Thread via GitHub
rdblue commented on code in PR #9277: URL: https://github.com/apache/iceberg/pull/9277#discussion_r1424398342 ## core/src/main/java/org/apache/iceberg/encryption/EncryptionUtil.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Core: Add StandardEncryptionManager [iceberg]

2023-12-12 Thread via GitHub
RussellSpitzer commented on code in PR #9277: URL: https://github.com/apache/iceberg/pull/9277#discussion_r1424319696 ## core/src/main/java/org/apache/iceberg/encryption/EncryptionUtil.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[PR] Core: Add StandardEncryptionManager [iceberg]

2023-12-11 Thread via GitHub
rdblue opened a new pull request, #9277: URL: https://github.com/apache/iceberg/pull/9277 This is an update to https://github.com/apache/iceberg/pull/6884 with a few final fixes to the `StandardEncryptionManager` and related classes. This is almost entirely @ggershinsky's work, I'm just sub