Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

github-actions[bot] commented on PR #11586: URL: https://github.com/apache/iceberg/pull/11586#issuecomment-2564878805 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

github-actions[bot] closed pull request #11586: Core,Format: Deprecate embedded manifests URL: https://github.com/apache/iceberg/pull/11586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

github-actions[bot] commented on PR #11586: URL: https://github.com/apache/iceberg/pull/11586#issuecomment-2558674282 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

Fokko commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1853667428 ## core/src/main/java/org/apache/iceberg/SnapshotParser.java: ## @@ -81,6 +84,9 @@ static void toJson(Snapshot snapshot, JsonGenerator generator) throws IOExceptio

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

flyrain commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1852683377 ## core/src/main/java/org/apache/iceberg/SnapshotParser.java: ## @@ -81,6 +84,9 @@ static void toJson(Snapshot snapshot, JsonGenerator generator) throws IOExceptio

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

adutra commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1848243185 ## core/src/main/java/org/apache/iceberg/SnapshotParser.java: ## @@ -81,6 +84,9 @@ static void toJson(Snapshot snapshot, JsonGenerator generator) throws IOExceptio

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

nastra commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1848820398 ## format/spec.md: ## @@ -654,17 +654,17 @@ The `first_row_id` is only inherited for added data files. The inherited value m A snapshot consists of the following f

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

amogh-jahagirdar commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1848789823 ## core/src/main/java/org/apache/iceberg/SnapshotParser.java: ## @@ -158,6 +164,9 @@ static Snapshot fromJson(JsonNode node) { manifestList);

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

amogh-jahagirdar commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1848789823 ## core/src/main/java/org/apache/iceberg/SnapshotParser.java: ## @@ -158,6 +164,9 @@ static Snapshot fromJson(JsonNode node) { manifestList);

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

amogh-jahagirdar commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1848789823 ## core/src/main/java/org/apache/iceberg/SnapshotParser.java: ## @@ -158,6 +164,9 @@ static Snapshot fromJson(JsonNode node) { manifestList);

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

nastra commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1848486487 ## core/src/main/java/org/apache/iceberg/SnapshotParser.java: ## @@ -81,6 +84,9 @@ static void toJson(Snapshot snapshot, JsonGenerator generator) throws IOExceptio

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

Fokko commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1848618516 ## format/spec.md: ## @@ -654,17 +654,17 @@ The `first_row_id` is only inherited for added data files. The inherited value m A snapshot consists of the following fi

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

Fokko commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1848615621 ## core/src/main/java/org/apache/iceberg/SnapshotParser.java: ## @@ -81,6 +84,9 @@ static void toJson(Snapshot snapshot, JsonGenerator generator) throws IOExceptio

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

nastra commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1848485291 ## core/src/main/java/org/apache/iceberg/BaseSnapshot.java: ## @@ -73,6 +73,12 @@ class BaseSnapshot implements Snapshot { this.v1ManifestLocations = null; }

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

nastra commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1848485291 ## core/src/main/java/org/apache/iceberg/BaseSnapshot.java: ## @@ -73,6 +73,12 @@ class BaseSnapshot implements Snapshot { this.v1ManifestLocations = null; }

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

nastra commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1848490686 ## format/spec.md: ## @@ -654,17 +654,17 @@ The `first_row_id` is only inherited for added data files. The inherited value m A snapshot consists of the following f

Re: [PR] Core,Format: Deprecate embedded manifests [iceberg]

nastra commented on code in PR #11586: URL: https://github.com/apache/iceberg/pull/11586#discussion_r1848487612 ## core/src/main/java/org/apache/iceberg/SnapshotParser.java: ## @@ -158,6 +164,9 @@ static Snapshot fromJson(JsonNode node) { manifestList); } else

[PR] Core,Format: Deprecate embedded manifests [iceberg]

Fokko opened a new pull request, #11586: URL: https://github.com/apache/iceberg/pull/11586 The embedded manifests are not used outside of the company where Iceberg found its inception. I think it is a good thing to officially deprecate this field, and be able to remove the `DummyFileIO` fro