Re: [PR] Core, Spark: Correct the delete record count for PartitionTable [iceberg]

2024-01-02 Thread via GitHub
ConeyLiu commented on PR #9389: URL: https://github.com/apache/iceberg/pull/9389#issuecomment-1874773959 Thanks @singhpk234 @RussellSpitzer @dramaticlly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Core, Spark: Correct the delete record count for PartitionTable [iceberg]

2024-01-02 Thread via GitHub
RussellSpitzer commented on PR #9389: URL: https://github.com/apache/iceberg/pull/9389#issuecomment-1874247332 LGTM! Thanks @ConeyLiu for the PR and @singhpk234 for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Core, Spark: Correct the delete record count for PartitionTable [iceberg]

2024-01-02 Thread via GitHub
RussellSpitzer merged PR #9389: URL: https://github.com/apache/iceberg/pull/9389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceb

Re: [PR] Core, Spark: Correct the delete record count for PartitionTable [iceberg]

2023-12-28 Thread via GitHub
ConeyLiu commented on PR #9389: URL: https://github.com/apache/iceberg/pull/9389#issuecomment-1871801687 Hi @nastra @Fokko @ajantha-bhat @dramaticlly could you help to review this when you are free? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to t

[PR] Core, Spark: Correct the delete record count for PartitionTable [iceberg]

2023-12-28 Thread via GitHub
ConeyLiu opened a new pull request, #9389: URL: https://github.com/apache/iceberg/pull/9389 The record counts for delete-file are calculated wrong in ParitionTable. For example, we got the following strange results. https://github.com/apache/iceberg/assets/12733256/a57f150c-0567-4439-8e57