Re: [PR] Config for deciding whether to use Iceberg Time type [iceberg]

2025-01-17 Thread via GitHub
bryanck commented on PR #11174: URL: https://github.com/apache/iceberg/pull/11174#issuecomment-2598431590 We have https://github.com/apache/iceberg/pull/11936 for a new SMT project. We can start adding some common transforms to that, rather than mixing transform logic into the sink itself.

Re: [PR] Config for deciding whether to use Iceberg Time type [iceberg]

2025-01-17 Thread via GitHub
braislchao commented on PR #11174: URL: https://github.com/apache/iceberg/pull/11174#issuecomment-2598160288 Hey! Just a quick follow up: I encountered the same issue when using the files generated by the connector with Spark, and I came to the same conclusion as @kumarpritam863 : co

Re: [PR] Config for deciding whether to use Iceberg Time type [iceberg]

2024-12-28 Thread via GitHub
github-actions[bot] commented on PR #11174: URL: https://github.com/apache/iceberg/pull/11174#issuecomment-2564565018 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Config for deciding whether to use Iceberg Time type [iceberg]

2024-12-28 Thread via GitHub
github-actions[bot] closed pull request #11174: Config for deciding whether to use Iceberg Time type URL: https://github.com/apache/iceberg/pull/11174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Config for deciding whether to use Iceberg Time type [iceberg]

2024-12-21 Thread via GitHub
github-actions[bot] commented on PR #11174: URL: https://github.com/apache/iceberg/pull/11174#issuecomment-2558276907 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Config for deciding whether to use Iceberg Time type [iceberg]

2024-11-20 Thread via GitHub
kumarpritam863 commented on PR #11174: URL: https://github.com/apache/iceberg/pull/11174#issuecomment-2490311787 Hi Bryan, I hope you're well. I wanted to follow up on this. It's been a while, and I'd appreciate the opportunity to discuss it further. -- This is an automated message from t

Re: [PR] Config for deciding whether to use Iceberg Time type [iceberg]

2024-11-16 Thread via GitHub
github-actions[bot] commented on PR #11174: URL: https://github.com/apache/iceberg/pull/11174#issuecomment-2480862755 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Config for deciding whether to use Iceberg Time type [iceberg]

2024-10-16 Thread via GitHub
kumarpritam863 commented on PR #11174: URL: https://github.com/apache/iceberg/pull/11174#issuecomment-2418322573 Hi Bryan, Thank you for your response. I completely agree with your view that the logic for Single Message Transforms (SMTs) should not be part of any sink. However, in th

Re: [PR] Config for deciding whether to use Iceberg Time type [iceberg]

2024-10-16 Thread via GitHub
bryanck commented on PR #11174: URL: https://github.com/apache/iceberg/pull/11174#issuecomment-2417600972 What we want is to keep transform logic out of the sink when possible. Our plan is to have a set of useful SMTs that we package w/ the connector, and this could be one of them. -- Th

Re: [PR] Config for deciding whether to use Iceberg Time type [iceberg]

2024-10-09 Thread via GitHub
kumarpritam863 commented on PR #11174: URL: https://github.com/apache/iceberg/pull/11174#issuecomment-2402751955 @bryanck thanks for the quick response. Kafka Connect SMT's are a bit slow and putting that just for this conversion would unnecessarily lower the performance. Also as there is n

Re: [PR] Config for deciding whether to use Iceberg Time type [iceberg]

2024-10-08 Thread via GitHub
bryanck commented on PR #11174: URL: https://github.com/apache/iceberg/pull/11174#issuecomment-2400139107 Have you considered using an SMT for this? I'm reluctant to add configs for each type conversion scenario. -- This is an automated message from the Apache Git Service. To respond to t