Re: [PR] Change Append/Overwrite API to accept snapshot properties [iceberg-python]

2024-03-19 Thread via GitHub
Fokko commented on PR #419: URL: https://github.com/apache/iceberg-python/pull/419#issuecomment-2007184688 Thanks @Gowthami03B for adding this 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Change Append/Overwrite API to accept snapshot properties [iceberg-python]

2024-03-19 Thread via GitHub
Fokko merged PR #419: URL: https://github.com/apache/iceberg-python/pull/419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Change Append/Overwrite API to accept snapshot properties [iceberg-python]

2024-03-19 Thread via GitHub
Fokko commented on code in PR #419: URL: https://github.com/apache/iceberg-python/pull/419#discussion_r1529938224 ## pyiceberg/table/__init__.py: ## @@ -2487,6 +2491,7 @@ def __init__( operation: Operation, transaction: Transaction, io: FileIO, +

Re: [PR] Change Append/Overwrite API to accept snapshot properties [iceberg-python]

2024-03-14 Thread via GitHub
Gowthami03B commented on code in PR #419: URL: https://github.com/apache/iceberg-python/pull/419#discussion_r1525754450 ## pyiceberg/table/__init__.py: ## @@ -1019,21 +1020,27 @@ def append(self, df: pa.Table) -> None: if len(self.spec().fields) > 0: raise

Re: [PR] Change Append/Overwrite API to accept snapshot properties [iceberg-python]

2024-03-14 Thread via GitHub
Gowthami03B commented on code in PR #419: URL: https://github.com/apache/iceberg-python/pull/419#discussion_r1524869065 ## pyiceberg/table/__init__.py: ## @@ -1019,21 +1020,27 @@ def append(self, df: pa.Table) -> None: if len(self.spec().fields) > 0: raise

Re: [PR] Change Append/Overwrite API to accept snapshot properties [iceberg-python]

2024-03-14 Thread via GitHub
Fokko commented on code in PR #419: URL: https://github.com/apache/iceberg-python/pull/419#discussion_r1524454409 ## pyiceberg/table/__init__.py: ## @@ -1019,21 +1020,27 @@ def append(self, df: pa.Table) -> None: if len(self.spec().fields) > 0: raise ValueE

Re: [PR] Change Append/Overwrite API to accept snapshot properties [iceberg-python]

2024-02-20 Thread via GitHub
Fokko commented on code in PR #419: URL: https://github.com/apache/iceberg-python/pull/419#discussion_r1496570473 ## pyiceberg/table/__init__.py: ## @@ -1019,21 +1020,27 @@ def append(self, df: pa.Table) -> None: if len(self.spec().fields) > 0: raise ValueE

Re: [PR] Change Append/Overwrite API to accept snapshot properties [iceberg-python]

2024-02-20 Thread via GitHub
Gowthami03B commented on PR #419: URL: https://github.com/apache/iceberg-python/pull/419#issuecomment-1955150881 > @Gowthami03B Now the release is out, we can merge this. Could you fix the merge conflicts? Thanks! @Fokko Done! -- This is an automated message from the Apache Git Ser

Re: [PR] Change Append/Overwrite API to accept snapshot properties [iceberg-python]

2024-02-20 Thread via GitHub
Fokko commented on PR #419: URL: https://github.com/apache/iceberg-python/pull/419#issuecomment-1955098638 @Gowthami03B Now the release is out, we can merge this. Could you fix the merge conflicts? Thanks! -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Change Append/Overwrite API to accept snapshot properties [iceberg-python]

2024-02-14 Thread via GitHub
Fokko commented on code in PR #419: URL: https://github.com/apache/iceberg-python/pull/419#discussion_r1489812651 ## mkdocs/docs/api.md: ## @@ -446,6 +446,20 @@ table = table.transaction().remove_properties("abc").commit_transaction() assert table.properties == {} ``` +## S