Re: [PR] Bump Spark 3.5.4 RC2 [iceberg]

2024-12-17 Thread via GitHub
pan3793 commented on code in PR #11731: URL: https://github.com/apache/iceberg/pull/11731#discussion_r1889519453 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java: ## @@ -59,6 +59,11 @@ public void close() { accessor.cl

Re: [PR] Bump Spark 3.5.4 RC2 [iceberg]

2024-12-17 Thread via GitHub
nastra commented on code in PR #11731: URL: https://github.com/apache/iceberg/pull/11731#discussion_r188902 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java: ## @@ -59,6 +59,11 @@ public void close() { accessor.clo

Re: [PR] Bump Spark 3.5.4 RC2 [iceberg]

2024-12-17 Thread via GitHub
pan3793 commented on PR #11731: URL: https://github.com/apache/iceberg/pull/11731#issuecomment-2548892617 @Fokko I opened #11802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Bump Spark 3.5.4 RC2 [iceberg]

2024-12-17 Thread via GitHub
Fokko commented on PR #11731: URL: https://github.com/apache/iceberg/pull/11731#issuecomment-2548667713 Thanks @pan3793 for catching this early. Could you create a separate PR for just the patch? We can include this in 1.7.2. -- This is an automated message from the Apache Git Service. To