github-actions[bot] commented on PR #10719:
URL: https://github.com/apache/iceberg/pull/10719#issuecomment-2480862560
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If
github-actions[bot] closed pull request #10719: Build: verify `gradle-wrapper
jar` integrity
URL: https://github.com/apache/iceberg/pull/10719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
github-actions[bot] commented on PR #10719:
URL: https://github.com/apache/iceberg/pull/10719#issuecomment-2466519703
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
snazy commented on PR #10719:
URL: https://github.com/apache/iceberg/pull/10719#issuecomment-2286625742
Thanks for the review, even though it's been about a month
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
snazy commented on code in PR #10719:
URL: https://github.com/apache/iceberg/pull/10719#discussion_r1715567355
##
gradle/gradlew-include.sh:
##
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Interesting - I think that is not ne
nastra commented on code in PR #10719:
URL: https://github.com/apache/iceberg/pull/10719#discussion_r1715240609
##
gradle/gradlew-include.sh:
##
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOT
snazy commented on code in PR #10719:
URL: https://github.com/apache/iceberg/pull/10719#discussion_r1706969784
##
gradle/gradlew-include.sh:
##
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTI
snazy commented on code in PR #10719:
URL: https://github.com/apache/iceberg/pull/10719#discussion_r1706966528
##
.gitignore:
##
@@ -17,8 +17,10 @@ out
build
dependencies.lock
**/dependencies.lock
-gradle/
Review Comment:
Because we have legit content in `gradle/` (ignore
RussellSpitzer commented on code in PR #10719:
URL: https://github.com/apache/iceberg/pull/10719#discussion_r1706689449
##
gradle/gradlew-include.sh:
##
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
RussellSpitzer commented on code in PR #10719:
URL: https://github.com/apache/iceberg/pull/10719#discussion_r1706687589
##
gradle/gradlew-include.sh:
##
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
RussellSpitzer commented on code in PR #10719:
URL: https://github.com/apache/iceberg/pull/10719#discussion_r1706683897
##
gradle/gradlew-include.sh:
##
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See
RussellSpitzer commented on code in PR #10719:
URL: https://github.com/apache/iceberg/pull/10719#discussion_r1706680236
##
.gitignore:
##
@@ -17,8 +17,10 @@ out
build
dependencies.lock
**/dependencies.lock
-gradle/
Review Comment:
Why are we removing the directory exclusi
snazy commented on PR #10719:
URL: https://github.com/apache/iceberg/pull/10719#issuecomment-2264761487
@RussellSpitzer you have time to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
snazy commented on PR #10719:
URL: https://github.com/apache/iceberg/pull/10719#issuecomment-2258121056
/cc @jbonofre
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
snazy opened a new pull request, #10719:
URL: https://github.com/apache/iceberg/pull/10719
Verifies the integrity of the `gradle-wrapper.jar` by checking the sha256
checksum and storing it locally. This also ensures that the
`gradle-wrapper.jar` automatically matches the Gradle version.
15 matches
Mail list logo