Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-11-16 Thread via GitHub
github-actions[bot] commented on PR #10719: URL: https://github.com/apache/iceberg/pull/10719#issuecomment-2480862560 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If

Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-11-16 Thread via GitHub
github-actions[bot] closed pull request #10719: Build: verify `gradle-wrapper jar` integrity URL: https://github.com/apache/iceberg/pull/10719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-11-09 Thread via GitHub
github-actions[bot] commented on PR #10719: URL: https://github.com/apache/iceberg/pull/10719#issuecomment-2466519703 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pul

Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-08-13 Thread via GitHub
snazy commented on PR #10719: URL: https://github.com/apache/iceberg/pull/10719#issuecomment-2286625742 Thanks for the review, even though it's been about a month -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-08-13 Thread via GitHub
snazy commented on code in PR #10719: URL: https://github.com/apache/iceberg/pull/10719#discussion_r1715567355 ## gradle/gradlew-include.sh: ## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Interesting - I think that is not ne

Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-08-13 Thread via GitHub
nastra commented on code in PR #10719: URL: https://github.com/apache/iceberg/pull/10719#discussion_r1715240609 ## gradle/gradlew-include.sh: ## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOT

Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-08-07 Thread via GitHub
snazy commented on code in PR #10719: URL: https://github.com/apache/iceberg/pull/10719#discussion_r1706969784 ## gradle/gradlew-include.sh: ## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTI

Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-08-07 Thread via GitHub
snazy commented on code in PR #10719: URL: https://github.com/apache/iceberg/pull/10719#discussion_r1706966528 ## .gitignore: ## @@ -17,8 +17,10 @@ out build dependencies.lock **/dependencies.lock -gradle/ Review Comment: Because we have legit content in `gradle/` (ignore

Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-08-07 Thread via GitHub
RussellSpitzer commented on code in PR #10719: URL: https://github.com/apache/iceberg/pull/10719#discussion_r1706689449 ## gradle/gradlew-include.sh: ## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-08-07 Thread via GitHub
RussellSpitzer commented on code in PR #10719: URL: https://github.com/apache/iceberg/pull/10719#discussion_r1706687589 ## gradle/gradlew-include.sh: ## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-08-07 Thread via GitHub
RussellSpitzer commented on code in PR #10719: URL: https://github.com/apache/iceberg/pull/10719#discussion_r1706683897 ## gradle/gradlew-include.sh: ## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-08-07 Thread via GitHub
RussellSpitzer commented on code in PR #10719: URL: https://github.com/apache/iceberg/pull/10719#discussion_r1706680236 ## .gitignore: ## @@ -17,8 +17,10 @@ out build dependencies.lock **/dependencies.lock -gradle/ Review Comment: Why are we removing the directory exclusi

Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-08-02 Thread via GitHub
snazy commented on PR #10719: URL: https://github.com/apache/iceberg/pull/10719#issuecomment-2264761487 @RussellSpitzer you have time to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-07-30 Thread via GitHub
snazy commented on PR #10719: URL: https://github.com/apache/iceberg/pull/10719#issuecomment-2258121056 /cc @jbonofre -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] Build: verify `gradle-wrapper jar` integrity [iceberg]

2024-07-18 Thread via GitHub
snazy opened a new pull request, #10719: URL: https://github.com/apache/iceberg/pull/10719 Verifies the integrity of the `gradle-wrapper.jar` by checking the sha256 checksum and storing it locally. This also ensures that the `gradle-wrapper.jar` automatically matches the Gradle version.