rdblue commented on PR #11001:
URL: https://github.com/apache/iceberg/pull/11001#issuecomment-2359292156
Thanks for doing the research and getting this in, @stevenzwu!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
RussellSpitzer commented on PR #11001:
URL: https://github.com/apache/iceberg/pull/11001#issuecomment-2356367551
Thanks @stevenzwu and @nastra and @jbonofre For Review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
RussellSpitzer merged PR #11001:
URL: https://github.com/apache/iceberg/pull/11001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
RussellSpitzer commented on PR #11001:
URL: https://github.com/apache/iceberg/pull/11001#issuecomment-2356365877
Ok, I think we are good to merge here. We can always revert if this ends up
causing issues that we haven't forseen.
--
This is an automated message from the Apache Git Service.
jbonofre commented on PR #11001:
URL: https://github.com/apache/iceberg/pull/11001#issuecomment-2356353914
Not yet but I don't want to hold this change. I propose to merge and as I'm
working on dependencies cleanup and versions alignement I will check at that
time.
--
This is an automate
RussellSpitzer commented on PR #11001:
URL: https://github.com/apache/iceberg/pull/11001#issuecomment-2356281104
@jbonofre Have you had a chance to check this again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dramaticlly commented on PR #11001:
URL: https://github.com/apache/iceberg/pull/11001#issuecomment-2310901452
change LGTM but dependent bot tried to upgrade in #9688 but @jbonofre
mentioned [there's -1 on this
upgrade](https://github.com/apache/iceberg/pull/9688#issuecomment-1935668919),
m
stevenzwu commented on PR #11001:
URL: https://github.com/apache/iceberg/pull/11001#issuecomment-2308591224
test logging seems to have been broken since `apache-iceberg-1.4.0` by mock
nets server
```
org.slf4j:slf4j-api:2.0.6
+--- org.mock-server:mockserver-client-java:5.15.0
stevenzwu commented on PR #11001:
URL: https://github.com/apache/iceberg/pull/11001#issuecomment-2308580403
right now, logging for tests is broken. it appears to affect both `main` and
`apache/1.6.x` branch.
```
SLF4J(W): No SLF4J providers were found.
SLF4J(W): Defaulting to no
