Fokko merged PR #249:
URL: https://github.com/apache/iceberg-python/pull/249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
MehulBatra commented on code in PR #249:
URL: https://github.com/apache/iceberg-python/pull/249#discussion_r1441371562
##
pyiceberg/table/__init__.py:
##
@@ -545,7 +545,7 @@ def new_snapshot_id(self) -> int:
def current_snapshot(self) -> Optional[Snapshot]:
"""Ge
Fokko commented on code in PR #249:
URL: https://github.com/apache/iceberg-python/pull/249#discussion_r1440884348
##
pyiceberg/table/__init__.py:
##
@@ -545,7 +545,7 @@ def new_snapshot_id(self) -> int:
def current_snapshot(self) -> Optional[Snapshot]:
"""Get the
MehulBatra commented on PR #249:
URL: https://github.com/apache/iceberg-python/pull/249#issuecomment-1875156254
Tested Locally all three seems to be passing
```
class DummyClass:
def __init__(self, metadata):
self.metadata = metadata
def test_snapshot_id
MehulBatra opened a new pull request, #249:
URL: https://github.com/apache/iceberg-python/pull/249
Resolves: [](https://github.com/apache/iceberg-python/issues/232)
Python, certain values are considered False in a boolean context. These
include None, 0, empty sequences/collections (`''`,
