Re: [PR] Aws: Add Iceberg version to UserAgent in S3 requests [iceberg]

2024-03-25 Thread via GitHub
CsengerG commented on PR #9963: URL: https://github.com/apache/iceberg/pull/9963#issuecomment-2018841589 Opened https://github.com/apache/iceberg/issues/10038 to track. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Aws: Add Iceberg version to UserAgent in S3 requests [iceberg]

2024-03-25 Thread via GitHub
amogh-jahagirdar merged PR #9963: URL: https://github.com/apache/iceberg/pull/9963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Aws: Add Iceberg version to UserAgent in S3 requests [iceberg]

2024-03-25 Thread via GitHub
amogh-jahagirdar commented on PR #9963: URL: https://github.com/apache/iceberg/pull/9963#issuecomment-2018700661 Since the failures were trottling errors from another service, I retried and they succeeded. If this is a consistent problem now in our CI, let's create a separate issue to track

Re: [PR] Aws: Add Iceberg version to UserAgent in S3 requests [iceberg]

2024-03-25 Thread via GitHub
nastra commented on PR #9963: URL: https://github.com/apache/iceberg/pull/9963#issuecomment-2018662340 > Looks like the link checker got throttled (HTTP 429s from Medium). Is this a known failure mode? FYI @Fokko -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Aws: Add Iceberg version to UserAgent in S3 requests [iceberg]

2024-03-25 Thread via GitHub
CsengerG commented on PR #9963: URL: https://github.com/apache/iceberg/pull/9963#issuecomment-2018358125 Looks like the link checker got throttled (HTTP 429s from Medium). Is this a known failure mode? -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Aws: Add Iceberg version to UserAgent in S3 requests [iceberg]

2024-03-25 Thread via GitHub
CsengerG commented on code in PR #9963: URL: https://github.com/apache/iceberg/pull/9963#discussion_r1537506185 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -819,6 +820,14 @@ public void applyS3AccessGrantsConfigurations(T buil } } +

Re: [PR] Aws: Add Iceberg version to UserAgent in S3 requests [iceberg]

2024-03-25 Thread via GitHub
nastra commented on code in PR #9963: URL: https://github.com/apache/iceberg/pull/9963#discussion_r1537430963 ## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java: ## @@ -819,6 +820,14 @@ public void applyS3AccessGrantsConfigurations(T buil } } + p

Re: [PR] Aws: Add Iceberg version to UserAgent in S3 requests [iceberg]

2024-03-25 Thread via GitHub
CsengerG commented on code in PR #9963: URL: https://github.com/apache/iceberg/pull/9963#discussion_r1537409548 ## aws/src/main/java/org/apache/iceberg/aws/s3/DefaultS3FileIOAwsClientFactory.java: ## @@ -54,6 +56,11 @@ public S3Client s3() { awsClientPropert

Re: [PR] Aws: Add Iceberg version to UserAgent in S3 requests [iceberg]

2024-03-21 Thread via GitHub
nastra commented on code in PR #9963: URL: https://github.com/apache/iceberg/pull/9963#discussion_r1533456221 ## aws/src/main/java/org/apache/iceberg/aws/s3/DefaultS3FileIOAwsClientFactory.java: ## @@ -54,6 +56,11 @@ public S3Client s3() { awsClientPropertie

Re: [PR] Aws: Add Iceberg version to UserAgent in S3 requests [iceberg]

2024-03-21 Thread via GitHub
nastra commented on code in PR #9963: URL: https://github.com/apache/iceberg/pull/9963#discussion_r1533455052 ## aws/src/main/java/org/apache/iceberg/aws/s3/DefaultS3FileIOAwsClientFactory.java: ## @@ -54,6 +56,11 @@ public S3Client s3() { awsClientPropertie

Re: [PR] Aws: Add Iceberg version to UserAgent in S3 requests [iceberg]

2024-03-20 Thread via GitHub
CsengerG commented on PR #9963: URL: https://github.com/apache/iceberg/pull/9963#issuecomment-2010197146 Hi @nastra, I've seen you reviewing PRs in the AWS space before, I was wondering if you could take a look at this (or suggest other reviewers who review S3-related code changes?). Thank

[PR] Aws: Add Iceberg version to UserAgent in S3 requests [iceberg]

2024-03-15 Thread via GitHub
CsengerG opened a new pull request, #9963: URL: https://github.com/apache/iceberg/pull/9963 This allows developers to monitor which version of Iceberg they have deployed to a cluster (for example, through the S3 Access Logs, which contain the user agent field). -- This is an automated me