Re: [PR] Avro: Add variant readers and writers [iceberg]

2025-03-06 Thread via GitHub
rdblue commented on code in PR #12457: URL: https://github.com/apache/iceberg/pull/12457#discussion_r1983693589 ## core/src/test/java/org/apache/iceberg/RandomVariants.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Avro: Add variant readers and writers [iceberg]

2025-03-06 Thread via GitHub
rdblue commented on code in PR #12457: URL: https://github.com/apache/iceberg/pull/12457#discussion_r1983699001 ## core/src/main/java/org/apache/iceberg/avro/ValueReaders.java: ## @@ -141,6 +144,13 @@ public static ValueReader decimalBytesReader(Schema schema) { } } +

Re: [PR] Avro: Add variant readers and writers [iceberg]

2025-03-06 Thread via GitHub
rdblue commented on code in PR #12457: URL: https://github.com/apache/iceberg/pull/12457#discussion_r1983693589 ## core/src/test/java/org/apache/iceberg/RandomVariants.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] Avro: Add variant readers and writers [iceberg]

2025-03-05 Thread via GitHub
aihuaxu commented on code in PR #12457: URL: https://github.com/apache/iceberg/pull/12457#discussion_r1982799286 ## core/src/main/java/org/apache/iceberg/avro/ValueReaders.java: ## @@ -141,6 +144,13 @@ public static ValueReader decimalBytesReader(Schema schema) { } }