Fokko closed pull request #183: Arrow: Allow missing field-ids from Schema
URL: https://github.com/apache/iceberg-python/pull/183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rdblue commented on code in PR #183:
URL: https://github.com/apache/iceberg-python/pull/183#discussion_r1424585279
##
pyiceberg/io/pyarrow.py:
##
@@ -713,28 +714,50 @@ def primitive(self, primitive: pa.DataType) ->
Optional[T]:
"""Visit a primitive type."""
-def _g
rdblue commented on PR #183:
URL: https://github.com/apache/iceberg-python/pull/183#issuecomment-1852828744
Per [my
comment](https://github.com/apache/iceberg-python/pull/183#discussion_r1424585279),
I'm -1 if the intent of this PR is to read data files without IDs. That must
use a name ma
HonahX commented on PR #183:
URL: https://github.com/apache/iceberg-python/pull/183#issuecomment-1849096950
Thanks for the detailed explanation! I was originally looking at how this PR
helps with reading, especially focusing on the code here:
https://github.com/apache/iceberg-python/blob/04
Fokko commented on PR #183:
URL: https://github.com/apache/iceberg-python/pull/183#issuecomment-1848669009
Thanks for the Java context here! Appreciate it!
> The table_schema must be processed with assign_field_id (or its equivalent
function in Java) before being written to the table.
Fokko commented on code in PR #183:
URL: https://github.com/apache/iceberg-python/pull/183#discussion_r1421564859
##
pyiceberg/io/pyarrow.py:
##
@@ -713,28 +721,49 @@ def primitive(self, primitive: pa.DataType) ->
Optional[T]:
"""Visit a primitive type."""
-def _ge
HonahX commented on code in PR #183:
URL: https://github.com/apache/iceberg-python/pull/183#discussion_r1419923194
##
pyiceberg/io/pyarrow.py:
##
@@ -713,28 +714,50 @@ def primitive(self, primitive: pa.DataType) ->
Optional[T]:
"""Visit a primitive type."""
-def _g
HonahX commented on code in PR #183:
URL: https://github.com/apache/iceberg-python/pull/183#discussion_r1419912292
##
pyiceberg/io/pyarrow.py:
##
@@ -713,28 +721,49 @@ def primitive(self, primitive: pa.DataType) ->
Optional[T]:
"""Visit a primitive type."""
-def _g
Fokko commented on code in PR #183:
URL: https://github.com/apache/iceberg-python/pull/183#discussion_r1419090834
##
pyiceberg/io/pyarrow.py:
##
@@ -713,28 +714,50 @@ def primitive(self, primitive: pa.DataType) ->
Optional[T]:
"""Visit a primitive type."""
-def _ge
Fokko commented on code in PR #183:
URL: https://github.com/apache/iceberg-python/pull/183#discussion_r1419083232
##
pyiceberg/io/pyarrow.py:
##
@@ -713,28 +714,50 @@ def primitive(self, primitive: pa.DataType) ->
Optional[T]:
"""Visit a primitive type."""
-def _ge
HonahX commented on code in PR #183:
URL: https://github.com/apache/iceberg-python/pull/183#discussion_r1418516560
##
pyiceberg/io/pyarrow.py:
##
@@ -713,28 +714,50 @@ def primitive(self, primitive: pa.DataType) ->
Optional[T]:
"""Visit a primitive type."""
-def _g
Fokko opened a new pull request, #183:
URL: https://github.com/apache/iceberg-python/pull/183
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
12 matches
Mail list logo
