Re: [PR] Api docs refactor [iceberg-python]

2023-10-26 Thread via GitHub
Fokko merged PR #106: URL: https://github.com/apache/iceberg-python/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Api docs refactor [iceberg-python]

2023-10-26 Thread via GitHub
Fokko commented on code in PR #106: URL: https://github.com/apache/iceberg-python/pull/106#discussion_r1373699406 ## mkdocs/docs/api.md: ## @@ -53,6 +53,11 @@ catalog = load_catalog( } ) ``` +If the catalog has not been initialized before, you need to run: Review Comment

Re: [PR] Api docs refactor [iceberg-python]

2023-10-26 Thread via GitHub
mobley-trent commented on PR #106: URL: https://github.com/apache/iceberg-python/pull/106#issuecomment-1781175804 @Fokko do you mind reviewing this PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Api docs refactor [iceberg-python]

2023-10-26 Thread via GitHub
mobley-trent opened a new pull request, #106: URL: https://github.com/apache/iceberg-python/pull/106 Fixes #78 - Adds the `location` parameter to the `catalog.create_table(...)` example for more context. - Adds the code to initialize the catalog in a database if this was not done