Re: [PR] Allow setting `write.parquet.page-row-limit` [iceberg-python]

2024-08-09 Thread via GitHub
Fokko merged PR #1017: URL: https://github.com/apache/iceberg-python/pull/1017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Allow setting `write.parquet.page-row-limit` [iceberg-python]

2024-08-08 Thread via GitHub
Fokko commented on PR #1017: URL: https://github.com/apache/iceberg-python/pull/1017#issuecomment-2275263994 I tried coming up with a test in two ways: - Inspecting the Parquet file through PyArrow to see if we can inspect the files, but the low-level page information is not exposed t

Re: [PR] Allow setting `write.parquet.page-row-limit` [iceberg-python]

2024-08-07 Thread via GitHub
ndrluis commented on PR #1017: URL: https://github.com/apache/iceberg-python/pull/1017#issuecomment-2274196689 WDYT about add a test verifying that the configuration from `write.parquet.page-row-limit` is passed down through `write_batch_size`as expected? -- This is an automated message

[PR] Allow setting `write.parquet.page-row-limit` [iceberg-python]

2024-08-07 Thread via GitHub
Fokko opened a new pull request, #1017: URL: https://github.com/apache/iceberg-python/pull/1017 Noticed this when working on https://github.com/apache/iceberg-python/pull/1016 It is being passed down to PyArrow here: https://github.com/apache/iceberg-python/blob/8aeab4951080fa