RussellSpitzer commented on PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#issuecomment-2442234431
Tests Passed and Merged
Thanks @jbonofre for the PR and @manuzhang , @findepi and @Fokko for the
review.
--
This is an automated message from the Apache Git Service.
To
RussellSpitzer merged PR #11291:
URL: https://github.com/apache/iceberg/pull/11291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
Fokko commented on PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#issuecomment-2441911132
@jbonofre @RussellSpitzer Took the liberty of fixing this through the GitHub
UI. Let's get this in 🚀
--
This is an automated message from the Apache Git Service.
To respond to the mess
RussellSpitzer commented on PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#issuecomment-2441899036
@jbonofre This has conflicts, @findepi you have the ability to merge this if
you are done reviewing :)
--
This is an automated message from the Apache Git Service.
To respond t
jbonofre commented on PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#issuecomment-2439877711
@findepi conflict resolved. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
findepi commented on PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#issuecomment-2437181487
@jbonofre there is a conflict, you may want to resolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
jbonofre commented on PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#issuecomment-2434638953
@rdblue @RussellSpitzer as discussed together, this is the PR to remove the
spring-boot dependency and use JDK HTTP server directly for mocking.
--
This is an automated message from
jbonofre commented on code in PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#discussion_r1814511669
##
aliyun/src/test/java/org/apache/iceberg/aliyun/TestUtility.java:
##
@@ -65,7 +65,7 @@ public static AliyunOSSExtension initialize() {
} else {
LOG.inf
manuzhang commented on code in PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#discussion_r1814144426
##
aliyun/src/test/java/org/apache/iceberg/aliyun/TestUtility.java:
##
@@ -65,7 +65,7 @@ public static AliyunOSSExtension initialize() {
} else {
LOG.in
jbonofre commented on PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#issuecomment-2432883972
@findepi @manuzhang I fixed the spotless. Sorry for the inconvenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jbonofre commented on PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#issuecomment-2432562122
I'm checking why one check failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
jbonofre commented on code in PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#discussion_r1803771650
##
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java:
##
@@ -121,8 +116,9 @@ void deleteBucket(String bucketName) throws IOExcepti
jbonofre commented on code in PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#discussion_r1799860746
##
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java:
##
@@ -121,8 +116,9 @@ void deleteBucket(String bucketName) throws IOExcepti
findepi commented on code in PR #11291:
URL: https://github.com/apache/iceberg/pull/11291#discussion_r1797752955
##
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockLocalStore.java:
##
@@ -121,8 +116,9 @@ void deleteBucket(String bucketName) throws IOExceptio
14 matches
Mail list logo
