Re: [PR] Added test about CDC creation failure after expiring all the snapshots [iceberg]

2024-10-14 Thread via GitHub
github-actions[bot] commented on PR #9141: URL: https://github.com/apache/iceberg/pull/9141#issuecomment-2412570736 This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If y

Re: [PR] Added test about CDC creation failure after expiring all the snapshots [iceberg]

2024-10-14 Thread via GitHub
github-actions[bot] closed pull request #9141: Added test about CDC creation failure after expiring all the snapshots URL: https://github.com/apache/iceberg/pull/9141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Added test about CDC creation failure after expiring all the snapshots [iceberg]

2023-12-18 Thread via GitHub
flyrain commented on PR #9141: URL: https://github.com/apache/iceberg/pull/9141#issuecomment-1861376560 Think a bit more, it will break the compatibility by changing the behavior of ExpireSnapshot procedure. Some users already relies on a combination of `delete` and `expire-snapshot` to rem

Re: [PR] Added test about CDC creation failure after expiring all the snapshots [iceberg]

2023-12-15 Thread via GitHub
flyrain commented on PR #9141: URL: https://github.com/apache/iceberg/pull/9141#issuecomment-1858649569 Sorry for the delay. Here is what happened. 1. s1 adds data file 1 in partition 1 2. s2 adds data file 2 in partition 2 3. s3 insert overwrite partition 2, which deletes data file

Re: [PR] Added test about CDC creation failure after expiring all the snapshots [iceberg]

2023-11-24 Thread via GitHub
flyrain commented on PR #9141: URL: https://github.com/apache/iceberg/pull/9141#issuecomment-1826229855 cc @aokolnychyi @RussellSpitzer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Added test about CDC creation failure after expiring all the snapshots [iceberg]

2023-11-24 Thread via GitHub
flyrain commented on PR #9141: URL: https://github.com/apache/iceberg/pull/9141#issuecomment-1826229811 Thanks a lot for the PR, @andreacfm! Will take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[PR] Added test about CDC creation failure after expiring all the snapshots [iceberg]

2023-11-23 Thread via GitHub
andreacfm opened a new pull request, #9141: URL: https://github.com/apache/iceberg/pull/9141 Added test about CDC creation failure after expiring all the snapshots. Test case: * update or delete at least a record in a table * expire all the snapshots (keep just the last one a