Re: [PR] Added force virtual addressing configuration for S3 [iceberg-python]

2024-12-02 Thread via GitHub
helmiazizm commented on code in PR #1392: URL: https://github.com/apache/iceberg-python/pull/1392#discussion_r1866939185 ## pyiceberg/io/pyarrow.py: ## @@ -350,7 +351,7 @@ def parse_location(location: str) -> Tuple[str, str, str]: return uri.scheme, uri.netloc, f"{u

Re: [PR] Added force virtual addressing configuration for S3 [iceberg-python]

2024-12-02 Thread via GitHub
helmiazizm commented on code in PR #1392: URL: https://github.com/apache/iceberg-python/pull/1392#discussion_r1866939185 ## pyiceberg/io/pyarrow.py: ## @@ -350,7 +351,7 @@ def parse_location(location: str) -> Tuple[str, str, str]: return uri.scheme, uri.netloc, f"{u

Re: [PR] Added force virtual addressing configuration for S3 [iceberg-python]

2024-12-02 Thread via GitHub
kevinjqliu commented on PR #1392: URL: https://github.com/apache/iceberg-python/pull/1392#issuecomment-2512403443 reopened @21, and added a few comments on this PR. Thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Added force virtual addressing configuration for S3 [iceberg-python]

2024-12-02 Thread via GitHub
kevinjqliu commented on code in PR #1392: URL: https://github.com/apache/iceberg-python/pull/1392#discussion_r1866397952 ## pyiceberg/io/pyarrow.py: ## @@ -350,7 +351,7 @@ def parse_location(location: str) -> Tuple[str, str, str]: return uri.scheme, uri.netloc, f"{u

[PR] Added force virtual addressing configuration for S3 [iceberg-python]

2024-12-01 Thread via GitHub
helmiazizm opened a new pull request, #1392: URL: https://github.com/apache/iceberg-python/pull/1392 Added the option to enforce virtual hosted style request for S3 PyArrow IO as it already has the [support](https://github.com/apache/arrow/issues/39779). Also added `oss://` and `r2://` prot