Re: [PR] Add tests for optimistic concurrency [iceberg-python]

2025-05-06 Thread via GitHub
Fokko commented on code in PR #1962: URL: https://github.com/apache/iceberg-python/pull/1962#discussion_r2075040539 ## tests/integration/test_writes/test_optimistic_concurrency.py: ## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

Re: [PR] Add tests for optimistic concurrency [iceberg-python]

2025-05-04 Thread via GitHub
hussein-awala commented on code in PR #1962: URL: https://github.com/apache/iceberg-python/pull/1962#discussion_r2072552413 ## tests/integration/test_writes/test_optimistic_concurrency.py: ## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mo

Re: [PR] Add tests for optimistic concurrency [iceberg-python]

2025-05-03 Thread via GitHub
Fokko commented on code in PR #1962: URL: https://github.com/apache/iceberg-python/pull/1962#discussion_r2072447068 ## tests/integration/test_writes/test_optimistic_concurrency.py: ## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

Re: [PR] Add tests for optimistic concurrency [iceberg-python]

2025-05-02 Thread via GitHub
smaheshwar-pltr commented on code in PR #1962: URL: https://github.com/apache/iceberg-python/pull/1962#discussion_r2072106756 ## tests/integration/test_writes/test_optimistic_concurrency.py: ## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[PR] Add tests for optimistic concurrency [iceberg-python]

2025-05-02 Thread via GitHub
Fokko opened a new pull request, #1962: URL: https://github.com/apache/iceberg-python/pull/1962 I think it would be great to also have integration tests that make it easy to replicate certain scenarios. Added some simple ones, but we can extend by having two tables that modify a diff