Re: [PR] Add table upsert support [iceberg-python]

2025-02-13 Thread via GitHub
kevinjqliu commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657959865 Thanks everyone for getting this over the finish line! Upsert has been a long awaited feature. I'm excited to include this as part of the upcoming 0.9.0 release. This is

Re: [PR] Add table upsert support [iceberg-python]

2025-02-13 Thread via GitHub
mattmartin14 commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657806614 > Great work @mattmartin14 👏🏻 👏🏻 > > If I'm not mistaken this is your first PR merged in any open source project correct? > > Not a bad first feature! Mine was ad

Re: [PR] Add table upsert support [iceberg-python]

2025-02-13 Thread via GitHub
bitsondatadev commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657742066 Great work @mattmartin14 👏🏻 👏🏻 If I'm not mistaken this is your first PR merged in any open source project correct? Not a bad first feature! Mine was adding [ar

Re: [PR] Add table upsert support [iceberg-python]

2025-02-13 Thread via GitHub
mattmartin14 commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657682312 @Fokko @kevinjqliu - should I go ahead and close the old PR now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Add table upsert support [iceberg-python]

2025-02-13 Thread via GitHub
mattmartin14 commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657667851 > This looks great! Thanks again @mattmartin14 > > Regarding @bitsondatadev's comment, when you do a squash and commit, you'll see multiple authors, example can be found

Re: [PR] Add table upsert support [iceberg-python]

2025-02-13 Thread via GitHub
Fokko commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657684518 @mattmartin14 Yes, please go ahead. Thanks everyone for driving this, @mattmartin14 in particular! -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Add table upsert support [iceberg-python]

2025-02-13 Thread via GitHub
Fokko merged PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Add table upsert support [iceberg-python]

2025-02-13 Thread via GitHub
bitsondatadev commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657648101 Hey @kevinjqliu, just a note after all the changes are done, it may be best to manually squash the commits and make sure Matt is the author for that...not sure what GitHub wi

Re: [PR] Add table upsert support [iceberg-python]

2025-02-13 Thread via GitHub
mattmartin14 commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657519239 > cc reviewers from the other PR (@Fokko / @corleyma / @tscottcoombes1 / @marcoaanogueira) and the original PR author @mattmartin14 Looks great to me. Thanks for getting

Re: [PR] Add table upsert support [iceberg-python]

2025-02-13 Thread via GitHub
kevinjqliu commented on PR #1660: URL: https://github.com/apache/iceberg-python/pull/1660#issuecomment-2657451094 cc reviewers from the other PR (@Fokko / @corleyma / @tscottcoombes1 / @marcoaanogueira) -- This is an automated message from the Apache Git Service. To respond to the

[PR] Add table upsert support [iceberg-python]

2025-02-13 Thread via GitHub
kevinjqliu opened a new pull request, #1660: URL: https://github.com/apache/iceberg-python/pull/1660 Closes #402 This PR adds the `upsert` function to Table and supports the following upsert operations: - when matched update all - when not matched insert all This PR is a rema