Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-15 Thread via GitHub
ehsantn commented on PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#issuecomment-3074384043 Thanks for the review and help @kevinjqliu ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-15 Thread via GitHub
kevinjqliu commented on PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#issuecomment-3074340735 Thanks for adding this @ehsantn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-15 Thread via GitHub
kevinjqliu merged PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@i

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-15 Thread via GitHub
ehsantn commented on PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#issuecomment-3073718392 > > @ehsantn i think this should make the tests more maintainable. wdyt? > > Sure, will work on it ASAP. Done. Let me know what you think. -- This is an automated me

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-14 Thread via GitHub
ehsantn commented on code in PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#discussion_r2206136677 ## tests/integration/test_writes/test_partitioned_writes.py: ## @@ -547,14 +552,14 @@ def test_summaries_with_null(spark: SparkSession, session_catalog: Catalog

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-14 Thread via GitHub
ehsantn commented on PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#issuecomment-3071665954 > @ehsantn i think this should make the tests more maintainable. wdyt? Sure, will work on it ASAP. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-14 Thread via GitHub
kevinjqliu commented on code in PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#discussion_r2206128117 ## tests/integration/test_writes/test_partitioned_writes.py: ## @@ -547,14 +552,14 @@ def test_summaries_with_null(spark: SparkSession, session_catalog: Cata

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-11 Thread via GitHub
ehsantn commented on PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#issuecomment-3063211683 @kevinjqliu please advise on next steps. This PR looks ready to merge to me and the flakiness of existing unit tests should be addressed separately (would be happy to contribute if

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-08 Thread via GitHub
ehsantn commented on code in PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#discussion_r2193638945 ## tests/integration/test_writes/test_partitioned_writes.py: ## @@ -451,6 +451,11 @@ def test_dynamic_partition_overwrite_unpartitioned_evolve_to_identity_trans

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-08 Thread via GitHub
ehsantn commented on code in PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#discussion_r2193638945 ## tests/integration/test_writes/test_partitioned_writes.py: ## @@ -451,6 +451,11 @@ def test_dynamic_partition_overwrite_unpartitioned_evolve_to_identity_trans

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-08 Thread via GitHub
kevinjqliu commented on code in PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#discussion_r2193523198 ## tests/integration/test_writes/test_partitioned_writes.py: ## @@ -451,6 +451,11 @@ def test_dynamic_partition_overwrite_unpartitioned_evolve_to_identity_tr

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-08 Thread via GitHub
ehsantn commented on PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#issuecomment-3050348312 All tests are passing locally for me now. Hopefully the CI works too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-08 Thread via GitHub
ehsantn commented on PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#issuecomment-3048960191 Ok, looks like the Bodo test is actually failing. Seems to be just a configuration issue. Working on a fix. https://github.com/apache/iceberg-python/actions/runs/16132597025/job

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-08 Thread via GitHub
ehsantn commented on PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#issuecomment-3048782148 Done. No idea why the CI fails here in unrelated tests. Maybe some dependency got upgraded in the lock file? -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-07 Thread via GitHub
kevinjqliu commented on PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#issuecomment-3047387247 maybe try rebase `main` again, idk what CI is doing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-07 Thread via GitHub
ehsantn commented on PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#issuecomment-3047167766 > @ehsantn i merged a few library upgrades. could you rebase this PR? Done. I assume the CI failure is not related to this PR? The test doesn't seem relevant. -- This is a

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-07 Thread via GitHub
kevinjqliu commented on PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#issuecomment-3047159027 @ehsantn i merged a few library upgrades. could you rebase this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Add support for Bodo DataFrame [iceberg-python]

2025-07-07 Thread via GitHub
ehsantn commented on PR #2167: URL: https://github.com/apache/iceberg-python/pull/2167#issuecomment-3046375134 Ok, updated Bodo to support Python 3.9 so this should work now. Tried `poetry install --all-extras` in an Ubuntu environment and it works. -- This is an automated message from th