Fokko commented on PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#issuecomment-1763395131
This is great, thanks @puchengy for fixing this 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Fokko merged PR #63:
URL: https://github.com/apache/iceberg-python/pull/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko commented on PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#issuecomment-1762074280
@puchengy I think this fixes it:
https://github.com/puchengy/iceberg-python/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Fokko commented on PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#issuecomment-1762064930
@puchengy let me give it a try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
puchengy commented on PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#issuecomment-1762044854
@Fokko thanks I will address that today or tomorrow. If this becomes a
blocker of the release, feel free to take it over.
--
This is an automated message from the Apache Git Service
Fokko commented on PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#issuecomment-1762031697
@puchengy
`make install && make lint` should fix it. It also looks like the
integration test is failing because FastAvro is missing the `spec_id` (and this
is correct because it
puchengy commented on PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#issuecomment-1762024206
@Fokko Will do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Fokko commented on PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#issuecomment-1762014542
@puchengy can you fix the CI? We need to make this part of 0.5.1 since the
`spec_id `was there before (as you pointed out on Slack :)
--
This is an automated message from the Apache Gi
Fokko commented on code in PR #63:
URL: https://github.com/apache/iceberg-python/pull/63#discussion_r1358033938
##
pyiceberg/manifest.py:
##
@@ -182,6 +182,7 @@ def __repr__(self) -> str:
doc="Splittable offsets",
),
NestedField(field_id=140, name=
