wgtmac commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2563408856
Yes, they have confirmed that there was a typo. Now it works:
https://github.com/apache/iceberg-cpp/actions/runs/12512760344
--
This is an automated message from the Apache Git Service.
Fokko commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2563379820
Looks like an issue on the INFRA end? For PyIceberg we also [just install
pre-commit](https://github.com/apache/iceberg-python/blob/main/.github/workflows/python-ci.yml)
and this works just
wgtmac commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2563262588
I have replied to the JIRA ticket. I guess it might have some
misconfigurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zhjwpku commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2563259290
> Apache allow-lists GitHub actions to use. I think for arrow-adbc I've just
manually installed and run pre-commit instead of using the dedicated action.
But https://issues.apache.o
lidavidm commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2563248835
Apache allow-lists GitHub actions to use. I think for arrow-adbc I've just
manually installed and run pre-commit instead of using the dedicated action.
--
This is an automated message
zhjwpku commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2563236285
> > pre-commit/action@v3.0.1 is not allowed to be used in apache/iceberg-cpp.
>
> It seems that pre-commit check never run successfully:
https://github.com/apache/iceberg-cpp/action
wgtmac commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2563226071
> pre-commit/action@v3.0.1 is not allowed to be used in apache/iceberg-cpp.
It seems that pre-commit check never run successfully:
https://github.com/apache/iceberg-cpp/actions/workf
Fokko merged PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
Fokko commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2559523819
@zhjwpku no action needed, let me get this in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
zhjwpku commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2559428937
> > Cool, I've raised an issue:
https://issues.apache.org/jira/browse/INFRA-26378
>
> It got approved :)
Hi @Fokko, I see the comment that the pre-commit/action@3.0.1 has bee
zhjwpku commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2550137994
> Should we also add some instructions on how to use `pre-commit`? Similar
to https://py.iceberg.apache.org/contributing/#linting
I've added some linting instructions to Contribute
zhjwpku commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2550134922
> > Cool, I've raised an issue:
https://issues.apache.org/jira/browse/INFRA-26378
>
> It got approved :)
Still got a startup error:
https://github.com/apache/iceberg-cpp/act
Fokko commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2549497161
> Cool, I've raised an issue:
https://issues.apache.org/jira/browse/INFRA-26378
It got approved :)
--
This is an automated message from the Apache Git Service.
To respond t
Fokko commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2548682321
Should we also add some instructions on how to use `pre-commit`? Similar to
https://py.iceberg.apache.org/contributing/#linting
--
This is an automated message from the Apache Git Service
Fokko commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2548679078
Cool, I've raised an issue: https://issues.apache.org/jira/browse/INFRA-26378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
raulcd commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2548613181
> you mean apache infra or github infra?
Apache Infra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
zhjwpku commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2548581125
> > @Fokko @raulcd there is startup error, do you have any experience on
this? https://github.com/apache/iceberg-cpp/actions/runs/12374293318
>
> Oh, it seems pre-commit is not an a
raulcd commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2548559200
> @Fokko @raulcd there is startup error, do you have any experience on this?
https://github.com/apache/iceberg-cpp/actions/runs/12374293318
Oh, it seems pre-commit is not an allowed
zhjwpku commented on code in PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#discussion_r1888564860
##
.github/workflows/pre-commit.yml:
##
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See t
zhjwpku commented on PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#issuecomment-2548505203
@Fokko @raulcd there is startup error, do you have any experience on this?
https://github.com/apache/iceberg-cpp/actions/runs/12374293318
--
This is an automated message from the Apac
raulcd commented on code in PR #16:
URL: https://github.com/apache/iceberg-cpp/pull/16#discussion_r1888530697
##
.github/workflows/pre-commit.yml:
##
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See th
zhjwpku opened a new pull request, #16:
URL: https://github.com/apache/iceberg-cpp/pull/16
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
22 matches
Mail list logo
