Re: [PR] Add new standards for deprecating APIs [iceberg-python]

2024-12-11 Thread via GitHub
ndrluis commented on code in PR #1365: URL: https://github.com/apache/iceberg-python/pull/1365#discussion_r1880601202 ## pyiceberg/catalog/__init__.py: ## @@ -631,9 +631,9 @@ def drop_view(self, identifier: Union[str, Identifier]) -> None: """ @deprecated( -

Re: [PR] Add new standards for deprecating APIs [iceberg-python]

2024-12-11 Thread via GitHub
Fokko commented on code in PR #1365: URL: https://github.com/apache/iceberg-python/pull/1365#discussion_r1880418065 ## pyiceberg/catalog/__init__.py: ## @@ -631,9 +631,9 @@ def drop_view(self, identifier: Union[str, Identifier]) -> None: """ @deprecated( -

Re: [PR] Add new standards for deprecating APIs [iceberg-python]

2024-12-11 Thread via GitHub
ndrluis commented on PR #1365: URL: https://github.com/apache/iceberg-python/pull/1365#issuecomment-2536298542 Some Deprecation Examples Future Deprecation https://github.com/user-attachments/assets/cfa68721-3a60-427b-94f2-36eb346b6825"; /> Deprecated https://github.com/u

Re: [PR] Add new standards for deprecating APIs [iceberg-python]

2024-11-24 Thread via GitHub
ndrluis commented on PR #1365: URL: https://github.com/apache/iceberg-python/pull/1365#issuecomment-2496258494 I copied the tests from Conda, but I think they aren't clear enough, so I plan to rewrite all of them. -- This is an automated message from the Apache Git Service. To respond to