Fokko merged PR #37:
URL: https://github.com/apache/iceberg-python/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
Fokko commented on code in PR #37:
URL: https://github.com/apache/iceberg-python/pull/37#discussion_r1346999502
##
pyiceberg/table/__init__.py:
##
@@ -1566,3 +1575,15 @@ def _add_and_move_fields(
elif len(moves) > 0:
return _move_fields(fields, moves)
return N
Fokko commented on PR #37:
URL: https://github.com/apache/iceberg-python/pull/37#issuecomment-1748353368
In Python, you cannot xor on ints/longs (probably because they are also
unbound in terms of size :), so I had to deviate a bit there.
--
This is an automated message from the Apache G
Fokko commented on code in PR #37:
URL: https://github.com/apache/iceberg-python/pull/37#discussion_r1344387785
##
pyiceberg/table/__init__.py:
##
@@ -1566,3 +1575,15 @@ def _add_and_move_fields(
elif len(moves) > 0:
return _move_fields(fields, moves)
return N
Fokko commented on code in PR #37:
URL: https://github.com/apache/iceberg-python/pull/37#discussion_r1344387785
##
pyiceberg/table/__init__.py:
##
@@ -1566,3 +1575,15 @@ def _add_and_move_fields(
elif len(moves) > 0:
return _move_fields(fields, moves)
return N
rdblue commented on code in PR #37:
URL: https://github.com/apache/iceberg-python/pull/37#discussion_r1344356017
##
pyiceberg/table/__init__.py:
##
@@ -1566,3 +1575,15 @@ def _add_and_move_fields(
elif len(moves) > 0:
return _move_fields(fields, moves)
return
Fokko opened a new pull request, #37:
URL: https://github.com/apache/iceberg-python/pull/37
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
