Re: [PR] Add logic for table format-version updates [iceberg-python]

2023-10-10 Thread via GitHub
Fokko merged PR #55: URL: https://github.com/apache/iceberg-python/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

Re: [PR] Add logic for table format-version updates [iceberg-python]

2023-10-10 Thread via GitHub
Fokko commented on PR #55: URL: https://github.com/apache/iceberg-python/pull/55#issuecomment-1754783886 @rdblue I agree with you there. I think we can still update the method name since it was just raising an exception. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Add logic for table format-version updates [iceberg-python]

2023-10-09 Thread via GitHub
rdblue commented on PR #55: URL: https://github.com/apache/iceberg-python/pull/55#issuecomment-1754068424 Looks good to me. I personally like using more descriptive verbs, like "upgrade" instead of "set" since this only allows upgrading the version, but I don't think it's a blocker (especia

[PR] Add logic for table format-version updates [iceberg-python]

2023-10-09 Thread via GitHub
Fokko opened a new pull request, #55: URL: https://github.com/apache/iceberg-python/pull/55 Add a few more tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr