Re: [PR] Add `list_views` for hive catalog [iceberg-python]

2024-11-22 Thread via GitHub
omkenge closed pull request #1251: Add `list_views` for hive catalog URL: https://github.com/apache/iceberg-python/pull/1251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add list_views for hive catalog [iceberg-python]

2024-10-31 Thread via GitHub
kevinjqliu commented on code in PR #1251: URL: https://github.com/apache/iceberg-python/pull/1251#discussion_r1824793043 ## pyiceberg/catalog/hive.py: ## @@ -407,7 +407,30 @@ def register_table(self, identifier: Union[str, Identifier], metadata_location: raise NotImple

Re: [PR] Add list_views for hive catalog [iceberg-python]

2024-10-28 Thread via GitHub
omkenge commented on PR #1251: URL: https://github.com/apache/iceberg-python/pull/1251#issuecomment-2442663561 Hi @kevinjqliu , ### Previous Situation In the existing implementation of the list_tables method within hive catalog, the functionality aimed to retrieve all tables under a sp

Re: [PR] Add list_views for hive catalog [iceberg-python]

2024-10-28 Thread via GitHub
kevinjqliu commented on PR #1251: URL: https://github.com/apache/iceberg-python/pull/1251#issuecomment-2442169570 > When I run the list_tables method, the output includes both Iceberg tables and views. However, when I check the list_tables method, it distinguishes between the tables based o

Re: [PR] Add list_views for hive catalog [iceberg-python]

2024-10-28 Thread via GitHub
omkenge commented on PR #1251: URL: https://github.com/apache/iceberg-python/pull/1251#issuecomment-2441585287 Hi @kevinjqliu, When I run the **list_tables** method, the output includes both Iceberg tables and views. However, when I check the list_tables method, it distinguishes betw

Re: [PR] Add list_views for hive catalog [iceberg-python]

2024-10-26 Thread via GitHub
omkenge commented on PR #1251: URL: https://github.com/apache/iceberg-python/pull/1251#issuecomment-2439411812 Hello @kevinjqliu As we discussed earlier, I created a PR for list_view for hive catalog Could you plz test it ? -- This is an automated message from the Apache Git Service

Re: [PR] Add list_views for hive catalog [iceberg-python]

2024-10-26 Thread via GitHub
omkenge commented on PR #1251: URL: https://github.com/apache/iceberg-python/pull/1251#issuecomment-2439411543 Hello @kbendick As we discussed earlier, I created a PR for list_view for hive catalog Could you plz test it ? -- This is an automated message from the Apache Git Service.

[PR] Add list_views for hive catalog [iceberg-python]

2024-10-26 Thread via GitHub
omkenge opened a new pull request, #1251: URL: https://github.com/apache/iceberg-python/pull/1251 Added list_views and test_list_views for hive catalog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g