github-actions[bot] commented on PR #9710:
URL: https://github.com/apache/iceberg/pull/9710#issuecomment-2433857259
This pull request has been closed due to lack of activity. This is not a
judgement on the merit of the PR in any way. It is just a way of keeping the PR
queue manageable. If y
github-actions[bot] closed pull request #9710: Add filter pushdown API for
contains and endsWith
URL: https://github.com/apache/iceberg/pull/9710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on PR #9710:
URL: https://github.com/apache/iceberg/pull/9710#issuecomment-2415379751
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
yabola commented on PR #9710:
URL: https://github.com/apache/iceberg/pull/9710#issuecomment-2081026195
@sujithjay could you also take a look since you implements `startWith`~
Spark on parquet also support `endsWith` and `contains`
https://github.com/apache/spark/blob/356830ada6c6ebbf54
yabola commented on PR #9710:
URL: https://github.com/apache/iceberg/pull/9710#issuecomment-2017140989
@amogh-jahagirdar Hi, please take a look if you have time~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
yabola commented on code in PR #9710:
URL: https://github.com/apache/iceberg/pull/9710#discussion_r1510203932
##
api/src/test/java/org/apache/iceberg/transforms/TestNotStartsWith.java:
##
@@ -106,23 +75,23 @@ public void
testTruncateStringWhenProjectedPredicateTermIsLongerThanW
yabola commented on code in PR #9710:
URL: https://github.com/apache/iceberg/pull/9710#discussion_r1510203932
##
api/src/test/java/org/apache/iceberg/transforms/TestNotStartsWith.java:
##
@@ -106,23 +75,23 @@ public void
testTruncateStringWhenProjectedPredicateTermIsLongerThanW
yabola commented on PR #9710:
URL: https://github.com/apache/iceberg/pull/9710#issuecomment-1975070635
@amogh-jahagirdar Thanks for your review! I have updated my code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
yabola commented on code in PR #9710:
URL: https://github.com/apache/iceberg/pull/9710#discussion_r1510200997
##
api/src/test/java/org/apache/iceberg/expressions/TestEvaluator.java:
##
@@ -348,6 +352,102 @@ public void testNotStartsWith() {
.isTrue();
}
+ @Test
+
amogh-jahagirdar commented on code in PR #9710:
URL: https://github.com/apache/iceberg/pull/9710#discussion_r1507790990
##
api/src/test/java/org/apache/iceberg/expressions/TestEvaluator.java:
##
@@ -348,6 +352,102 @@ public void testNotStartsWith() {
.isTrue();
}
+
amogh-jahagirdar commented on PR #9710:
URL: https://github.com/apache/iceberg/pull/9710#issuecomment-1961629871
Sorry for the delay @yabola , got busy with some other work, I haven't
forgotten about this PR! When my time frees up I'll review this.
--
This is an automated message from the
yabola commented on PR #9710:
URL: https://github.com/apache/iceberg/pull/9710#issuecomment-1961363628
@amogh-jahagirdar Hi, if you have time, please take a look~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
12 matches
Mail list logo
