kevinjqliu commented on PR #1610:
URL: https://github.com/apache/iceberg-python/pull/1610#issuecomment-2648794609
Thanks @tom-s-powell for the PR. And thank you @Fokko for the review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
kevinjqliu merged PR #1610:
URL: https://github.com/apache/iceberg-python/pull/1610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
Fokko commented on PR #1610:
URL: https://github.com/apache/iceberg-python/pull/1610#issuecomment-2647935293
Looks like the `test_s3v4_rest_signer` test needs a bit of TLC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
tom-s-powell commented on PR #1610:
URL: https://github.com/apache/iceberg-python/pull/1610#issuecomment-2647504110
@Fokko done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
Fokko commented on PR #1610:
URL: https://github.com/apache/iceberg-python/pull/1610#issuecomment-2647193310
@tom-s-powell Could you run the linter using `make lint`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
tom-s-powell commented on PR #1610:
URL: https://github.com/apache/iceberg-python/pull/1610#issuecomment-2643630453
Could I check what sort of documentation you'd want to see?
> To configure custom headers in RESTCatalog, include them in the catalog
properties with the prefix `header.`.
Fokko commented on code in PR #1610:
URL: https://github.com/apache/iceberg-python/pull/1610#discussion_r1943253743
##
pyiceberg/utils/properties.py:
##
@@ -74,3 +77,13 @@ def get_first_property_value(
if property_value := properties.get(property_name):
ret
Fokko commented on PR #1610:
URL: https://github.com/apache/iceberg-python/pull/1610#issuecomment-2637373120
Thanks for working on this @tom-s-powell, could you also add this to the
documentation:
https://github.com/apache/iceberg-python/blob/main/mkdocs/docs/configuration.md#rest-catalog?
