Re: [PR] Add TableMetadataBuilder::assign_current_snapshot_id [iceberg-rust]

2024-11-22 Thread via GitHub
SergeiPatiakin commented on PR #713: URL: https://github.com/apache/iceberg-rust/pull/713#issuecomment-2493974787 Thanks! You are right, I think I'll be able to use `TableMetadataBuilder::set_ref` from https://github.com/apache/iceberg-rust/pull/587 . Closing this PR -- This is an automa

Re: [PR] Add TableMetadataBuilder::assign_current_snapshot_id [iceberg-rust]

2024-11-22 Thread via GitHub
SergeiPatiakin closed pull request #713: Add TableMetadataBuilder::assign_current_snapshot_id URL: https://github.com/apache/iceberg-rust/pull/713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add TableMetadataBuilder::assign_current_snapshot_id [iceberg-rust]

2024-11-22 Thread via GitHub
c-thiel commented on PR #713: URL: https://github.com/apache/iceberg-rust/pull/713#issuecomment-2493900023 Thanks @SergeiPatiakin for your PR! Assigning the current snapshot id is a bit more complex than what you have in your PR. Here is the extract from the spec: https://iceberg.

[PR] Add TableMetadataBuilder::assign_current_snapshot_id [iceberg-rust]

2024-11-22 Thread via GitHub
SergeiPatiakin opened a new pull request, #713: URL: https://github.com/apache/iceberg-rust/pull/713 `TableMetadataBuilder::from_table_creation` initializes `current_snapshot_id` to `None`. This PR adds a builder method that allows different values. -- This is an automated message from t