Re: [PR] Add Strict projection [iceberg-python]

2024-12-10 Thread via GitHub
Fokko commented on code in PR #539: URL: https://github.com/apache/iceberg-python/pull/539#discussion_r1879028369 ## pyiceberg/transforms.py: ## @@ -766,6 +858,47 @@ def _truncate_number( return None +def _truncate_number_strict( +name: str, pred: BoundLiteralPr

Re: [PR] Add Strict projection [iceberg-python]

2024-12-10 Thread via GitHub
Fokko commented on code in PR #539: URL: https://github.com/apache/iceberg-python/pull/539#discussion_r1879010689 ## pyiceberg/transforms.py: ## @@ -766,6 +858,47 @@ def _truncate_number( return None +def _truncate_number_strict( +name: str, pred: BoundLiteralPr

Re: [PR] Add Strict projection [iceberg-python]

2024-12-09 Thread via GitHub
Fokko commented on code in PR #539: URL: https://github.com/apache/iceberg-python/pull/539#discussion_r1876738534 ## pyiceberg/transforms.py: ## @@ -766,6 +858,47 @@ def _truncate_number( return None +def _truncate_number_strict( +name: str, pred: BoundLiteralPr

Re: [PR] Add Strict projection [iceberg-python]

2024-12-09 Thread via GitHub
ZENOTME commented on code in PR #539: URL: https://github.com/apache/iceberg-python/pull/539#discussion_r1876215827 ## pyiceberg/transforms.py: ## @@ -766,6 +858,47 @@ def _truncate_number( return None +def _truncate_number_strict( +name: str, pred: BoundLiteral

Re: [PR] Add Strict projection [iceberg-python]

2024-03-25 Thread via GitHub
Fokko merged PR #539: URL: https://github.com/apache/iceberg-python/pull/539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Add Strict projection [iceberg-python]

2024-03-25 Thread via GitHub
Fokko commented on code in PR #539: URL: https://github.com/apache/iceberg-python/pull/539#discussion_r1537396771 ## pyiceberg/transforms.py: ## @@ -521,6 +556,16 @@ def project(self, name: str, pred: BoundPredicate[L]) -> Optional[UnboundPredica else: rai

Re: [PR] Add Strict projection [iceberg-python]

2024-03-25 Thread via GitHub
HonahX commented on code in PR #539: URL: https://github.com/apache/iceberg-python/pull/539#discussion_r1537148759 ## pyiceberg/transforms.py: ## @@ -521,6 +556,16 @@ def project(self, name: str, pred: BoundPredicate[L]) -> Optional[UnboundPredica else: ra

[PR] Add Strict projection [iceberg-python]

2024-03-21 Thread via GitHub
Fokko opened a new pull request, #539: URL: https://github.com/apache/iceberg-python/pull/539 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e