Re: [PR] Add Spark UI metrics from Iceberg scan metrics [iceberg]

2023-11-02 Thread via GitHub
aokolnychyi commented on PR #8717: URL: https://github.com/apache/iceberg/pull/8717#issuecomment-1791771494 Thanks, @karuppayya! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Add Spark UI metrics from Iceberg scan metrics [iceberg]

2023-11-02 Thread via GitHub
aokolnychyi merged PR #8717: URL: https://github.com/apache/iceberg/pull/8717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg

Re: [PR] Add Spark UI metrics from Iceberg scan metrics [iceberg]

2023-11-02 Thread via GitHub
karuppayya commented on PR #8717: URL: https://github.com/apache/iceberg/pull/8717#issuecomment-1791205092 Thanks @aokolnychyi for the review, i have addressed the latest comments, ready for another round -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] Add Spark UI metrics from Iceberg scan metrics [iceberg]

2023-11-01 Thread via GitHub
aokolnychyi commented on code in PR #8717: URL: https://github.com/apache/iceberg/pull/8717#discussion_r1379552388 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java: ## @@ -200,12 +220,31 @@ public CustomTaskMetric[] reportDriverMetrics() { }

Re: [PR] Add Spark UI metrics from Iceberg scan metrics [iceberg]

2023-10-09 Thread via GitHub
aokolnychyi commented on code in PR #8717: URL: https://github.com/apache/iceberg/pull/8717#discussion_r1350766227 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java: ## @@ -207,6 +223,15 @@ public CustomTaskMetric[] reportDriverMetrics() { dri

Re: [PR] Add Spark UI metrics from Iceberg scan metrics [iceberg]

2023-10-09 Thread via GitHub
aokolnychyi commented on PR #8717: URL: https://github.com/apache/iceberg/pull/8717#issuecomment-1753550229 Let me take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen